<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<p><br>
</p>
<br>
<div class="moz-cite-prefix">On 06/22/2016 04:37 PM, Lenka Doudova
wrote:<br>
</div>
<blockquote
cite="mid:8900bfe6-6495-aaa9-39ce-c201cb5b25a0@redhat.com"
type="cite">
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
<p><br>
</p>
<br>
<div class="moz-cite-prefix">On 06/22/2016 08:33 AM, Martin Basti
wrote:<br>
</div>
<blockquote
cite="mid:33c965cf-ac80-5e8e-feae-81a48ba81fba@redhat.com"
type="cite">
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
<p><br>
</p>
<br>
<div class="moz-cite-prefix">On 22.06.2016 07:37, Lenka Doudova
wrote:<br>
</div>
<blockquote
cite="mid:4ab90b76-0a95-40cd-8721-783d8908d37c@redhat.com"
type="cite">
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
<p><br>
</p>
<br>
<div class="moz-cite-prefix">On 06/21/2016 06:57 PM, Martin
Basti wrote:<br>
</div>
<blockquote
cite="mid:5d0b933a-d96d-8dfa-a0f3-e59240618f67@redhat.com"
type="cite">
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
<p><br>
</p>
<br>
<div class="moz-cite-prefix">On 21.06.2016 15:39, Lenka
Doudova wrote:<br>
</div>
<blockquote
cite="mid:6ff234ed-6cf3-7742-b388-d192f27e40a7@redhat.com"
type="cite">Hi, <br>
<br>
attaching patch for failing location tests
(ipatests/test_xmlrpc/test_location_plugin.py). <br>
<br>
Lenka <br>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
<br>
Hello,<br>
<br>
1)<br>
+ expected_updates={u'ipalocation_location':
[location.idnsname_obj],<br>
+ u'enabled_role_servrole': (<br>
+ u'CA server', u'DNS
server', u'NTP server')},<br>
<br>
This depends on services installed on server, so server
without DNS will cause test failures. We probably should
skip test id DNS isn't installed.<br>
Without DNS installed you get much more different warnings<br>
<br>
<br>
2)<br>
+ def update(self, updates, expected_updates=None,
messages=None):<br>
....<br>
+ self.messages = messages<br>
<br>
Why is this needed? I'm puzzled by this<br>
<br>
It is defined outside __init__ what is wrong and it is never
used.<br>
<br>
</blockquote>
Hi, thanks for review.<br>
ad 1: will fix<br>
ad 2: the 'messages' key is indeed used, because this key is
returned every time a server is attached to/removed from a
location. If the 'messages' is not supplied to the result
comparison, the test fails (see <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="https://paste.fedoraproject.org/382936/65732411/">https://paste.fedoraproject.org/382936/65732411/</a>
for result of test without applied patch).<br>
<br>
Lenka<br>
</blockquote>
<br>
Please point me to the line where ServerTracker.messages is
used, I still don't see it. In your fpaste, removed
self.messages in that context is TestLocationsServer.messages
not ServerTracker.messages<br>
<br>
Martin^2<br>
</blockquote>
<br>
Ah, right you are, my good sir. I fixed both issues, hopefully
will be fine now. Fixed patch attached.<br>
Lenka<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
Self NACK, will provide some more changes tomorrow.<br>
Lenka<br>
</body>
</html>