<html> <head> <meta content="text/html; charset=windows-1252" http-equiv="Content-Type"> </head> <body bgcolor="#FFFFFF" text="#000000"> Hi Florence, <div class="moz-cite-prefix">On 07/07/2016 03:30 PM, Florence Blanc-Renaud wrote: </div> <blockquote cite="mid:0d70dfbb-db6a-5df4-858b-1181404ef147@redhat.com" type="cite">On 07/07/2016 10:58 AM, Abhijeet Kasurde wrote: <blockquote type="cite">Hi All, Please review the patch. Fixes : <a class="moz-txt-link-freetext" href="https://fedorahosted.org/freeipa/ticket/6031">https://fedorahosted.org/freeipa/ticket/6031</a> -- Thanks, Abhijeet Kasurde IRC: akasurde <a class="moz-txt-link-freetext" href="http://akasurde.github.io">http://akasurde.github.io</a> </blockquote> Hi Abhijeet, thanks for your patch. I have a comment though: if the filename is modified in ipa-backup, then it should also be changed in ipa-restore, to make sure that the backup can be restored. It may be a good idea to define the file name as a constant and use this constant everywhere. </blockquote> I will change ipa-restore as well. <blockquote cite="mid:0d70dfbb-db6a-5df4-858b-1181404ef147@redhat.com" type="cite">As far as I can see, the tool ipa-restore checks that the backup version and ipa-restore version are consistent, meaning that both tools should use the same filename and that it will not break backward compatibility, but other team members can confirm. </blockquote> I will wait for other team members to comment on this. <blockquote cite="mid:0d70dfbb-db6a-5df4-858b-1181404ef147@redhat.com" type="cite">Flo. </blockquote> Thanks for your comments. <pre class="moz-signature" cols="72">-- Thanks, Abhijeet Kasurde IRC: akasurde <a class="moz-txt-link-freetext" href="http://akasurde.github.io">http://akasurde.github.io</a> </pre> </body> </html>