<html> <head> <meta content="text/html; charset=windows-1252" http-equiv="Content-Type"> </head> <body bgcolor="#FFFFFF" text="#000000"> Thanks for the review! Comments below. <div class="moz-cite-prefix">On 07/01/2016 07:42 AM, Martin Basti wrote: </div> <blockquote cite="mid:3fe0b9ae-9b22-3a9a-3d4a-067c51a22452@redhat.com" type="cite"> <meta content="text/html; charset=windows-1252" http-equiv="Content-Type"> <div class="moz-cite-prefix">On 29.06.2016 20:46, Ben Lipton wrote: </div> <blockquote cite="mid:dae97497-2ee4-3533-da66-f548500773a6@redhat.com" type="cite">The attached patch silences some annoying messages I've been getting when upgrading the freeipa-client package on F24: """ WARNING: 'UseLogin yes' is not supported in Fedora and may cause several problems. </blockquote> </blockquote> This will be fixed by openssh-7.2p2-9.fc24 (<a class="moz-txt-link-freetext" href="https://bugzilla.redhat.com/show_bug.cgi?id=1350347"><a class="moz-txt-link-freetext" href="https://bugzilla.redhat.com/show_bug.cgi?id=1350347">https://bugzilla.redhat.com/show_bug.cgi?id=1350347</a></a>) so we probably shouldn't worry about it. <blockquote cite="mid:3fe0b9ae-9b22-3a9a-3d4a-067c51a22452@redhat.com" type="cite"> <blockquote cite="mid:dae97497-2ee4-3533-da66-f548500773a6@redhat.com" type="cite"> Could not load host key: /etc/ssh/ssh_host_dsa_key </blockquote> </blockquote> This is because by default sshd looks for all of /etc/ssh/ssh_host_dsa_key, /etc/ssh/ssh_host_ecdsa_key, /etc/ssh/ssh_host_ed25519_key and /etc/ssh/ssh_host_rsa_key, but Fedora doesn't generate a DSA key by default. <blockquote cite="mid:3fe0b9ae-9b22-3a9a-3d4a-067c51a22452@redhat.com" type="cite"> <blockquote cite="mid:dae97497-2ee4-3533-da66-f548500773a6@redhat.com" type="cite"> """ Since the script causing the message only looks at the return code from sshd to determine the right options to use, I thought it might be ok to discard the output. What do you think? Ben <fieldset class="mimeAttachmentHeader"></fieldset> </blockquote> Hello, I don't like to hiding errors/warnings. Can you determine and solve the root cause? </blockquote> I definitely agree with this in principle, but in this case the purpose of this code is to try different, potentially wrong, parameters to sshd until it finds a combination that it accepts. It seems like in some environments this would produce error messages that aren't actionable and don't indicate any problem for package function, which is why I didn't think these messages were necessarily worth preserving. On the other hand, if the code makes the wrong decision about sshd version we might be interested in error logs that show why. Can we log this to a file instead of the console, maybe? If you'd prefer just addressing the root cause, a patch that prevents the missing host key error is attached, but it won't stop the error messages showing up when openssh is an older version. Thanks, Ben </body> </html>