<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<p><br>
</p>
<br>
<div class="moz-cite-prefix">On 07/20/2016 04:51 PM, Pavel Vomacka
wrote:<br>
</div>
<blockquote
cite="mid:3e447bbe-fade-c5e5-2415-15ed7ae0b2ea@redhat.com"
type="cite">Please review attached patches, which add tests for
new certificate widget in WebUI. <br>
<br>
<a class="moz-txt-link-freetext"
href="https://fedorahosted.org/freeipa/ticket/6064">https://fedorahosted.org/freeipa/ticket/6064</a>
<br>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
Hi, <br>
thanks for patches.<br>
Functionally ok, but you have lots of PEP8 errors in patches 78, 80,
81 and 82 -> NACK.<br>
Also in patch 82, method test_arbitrary_certificate, comment says
user needs to have "arbitrary_cert" configured, but the property in
config file is correctly "arbitrary_cert_path", so it's a bit
misleading.<br>
<br>
Patch 79 is OK, ACK.<br>
<br>
Lenka<br>
</body>
</html>