<html> <head> <meta content="text/html; charset=windows-1252" http-equiv="Content-Type"> </head> <body bgcolor="#FFFFFF" text="#000000"> <div class="moz-cite-prefix">On 07/28/2016 08:16 AM, Lenka Doudova wrote: </div> <blockquote cite="mid:7298654a-0ea9-8f42-dc24-f48f0dabeeb4@redhat.com" type="cite"> <meta content="text/html; charset=windows-1252" http-equiv="Content-Type"> <div class="moz-cite-prefix">On 07/20/2016 04:51 PM, Pavel Vomacka wrote: </div> <blockquote cite="mid:3e447bbe-fade-c5e5-2415-15ed7ae0b2ea@redhat.com" type="cite">Please review attached patches, which add tests for new certificate widget in WebUI. <a moz-do-not-send="true" class="moz-txt-link-freetext" href="https://fedorahosted.org/freeipa/ticket/6064">https://fedorahosted.org/freeipa/ticket/6064</a> <fieldset class="mimeAttachmentHeader"></fieldset> </blockquote> Hi, thanks for patches. Functionally ok, but you have lots of PEP8 errors in patches 78, 80, 81 and 82 -> NACK. Also in patch 82, method test_arbitrary_certificate, comment says user needs to have "arbitrary_cert" configured, but the property in config file is correctly "arbitrary_cert_path", so it's a bit misleading. Patch 79 is OK, ACK. Lenka <fieldset class="mimeAttachmentHeader"></fieldset> </blockquote> Thank you for review. Attaching patches which have fixed all pep8 erros. Bad property of config file was also mentioned in patch 81. These are also fixed. <pre class="moz-signature" cols="72">-- Pavel^3 Vomacka</pre> </body> </html>