<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<p><br>
</p>
<br>
<div class="moz-cite-prefix">On 01.08.2016 16:13, Lenka Doudova
wrote:<br>
</div>
<blockquote
cite="mid:4864a490-3217-8d81-8e5f-d341fef661ea@redhat.com"
type="cite">
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
<p><br>
</p>
<br>
<div class="moz-cite-prefix">On 07/29/2016 03:00 PM, Pavel Vomacka
wrote:<br>
</div>
<blockquote
cite="mid:aa7a986e-e07e-9d1b-0c87-2efbd51c2afc@redhat.com"
type="cite">
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
<p><br>
</p>
<br>
<div class="moz-cite-prefix">On 07/28/2016 08:16 AM, Lenka
Doudova wrote:<br>
</div>
<blockquote
cite="mid:7298654a-0ea9-8f42-dc24-f48f0dabeeb4@redhat.com"
type="cite">
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
<p><br>
</p>
<br>
<div class="moz-cite-prefix">On 07/20/2016 04:51 PM, Pavel
Vomacka wrote:<br>
</div>
<blockquote
cite="mid:3e447bbe-fade-c5e5-2415-15ed7ae0b2ea@redhat.com"
type="cite">Please review attached patches, which add tests
for new certificate widget in WebUI. <br>
<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://fedorahosted.org/freeipa/ticket/6064">https://fedorahosted.org/freeipa/ticket/6064</a>
<br>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
Hi, <br>
thanks for patches.<br>
Functionally ok, but you have lots of PEP8 errors in patches
78, 80, 81 and 82 -> NACK.<br>
Also in patch 82, method test_arbitrary_certificate, comment
says user needs to have "arbitrary_cert" configured, but the
property in config file is correctly "arbitrary_cert_path", so
it's a bit misleading.<br>
<br>
Patch 79 is OK, ACK.<br>
<br>
Lenka<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
Thank you for review. Attaching patches which have fixed all
pep8 erros. Bad property of config file was also mentioned in
patch 81. These are also fixed.<br>
<br>
<pre class="moz-signature" cols="72">--
Pavel^3 Vomacka</pre>
</blockquote>
Hi,<br>
<br>
all is fine now, ACK for all patches.<br>
<br>
Lenka<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
master:<br>
* 26803a0d173192ee05878dd47c22a95b4432d078 Add possibility to choose
parent element by css<br>
* 45825b84b0d140f62e1459c3b5dbb5281229cad6 Add function which check
whether the field is empty<br>
* 37c0bd1dd6e19dd4afefb47ab52ace0a25f2ca82 TEST: managing user
certificates<br>
* 20e8cef394993855fb291cb55684fe3facad82aa TEST: managing host
certificates<br>
* 5f5203eb620d21244d3c39ee25ba8f093106122b TEST: managing service
certificates<br>
<br>
</body>
</html>