<html> <head> <meta content="text/html; charset=windows-1252" http-equiv="Content-Type"> </head> <body bgcolor="#FFFFFF" text="#000000"> <div class="moz-cite-prefix">On 28.07.2016 18:29, Ariel Barria wrote: </div> <blockquote cite="mid:CANvnMC2+kkSDsS+KgYu-tQZWHTgsR=ZC2y4qiYhNgoxnhvMUuw@mail.gmail.com" type="cite"> <pre wrap="">2016-07-28 7:10 GMT-05:00 Petr Spacek <a class="moz-txt-link-rfc2396E" href="mailto:pspacek@redhat.com"><pspacek@redhat.com></a>: </pre> <blockquote type="cite"> <pre wrap="">On 27.7.2016 18:26, Ariel Barria wrote: </pre> <blockquote type="cite"> <pre wrap="">2016-07-26 9:39 GMT-05:00 Petr Spacek <a class="moz-txt-link-rfc2396E" href="mailto:pspacek@redhat.com"><pspacek@redhat.com></a>: </pre> <blockquote type="cite"> <pre wrap="">On 26.7.2016 16:28, Jan Cholasta wrote: </pre> <blockquote type="cite"> <pre wrap="">Hi, On 26.7.2016 16:09, Martin Basti wrote: </pre> <blockquote type="cite"> <pre wrap=""> On 22.07.2016 00:14, Ariel Barria wrote: </pre> <blockquote type="cite"> <pre wrap="">Hello everyone. I send patch for review. </pre> </blockquote> </blockquote> <pre wrap=""> NACK, six.u() is supposed to be used on string literals *only* [1]. A proper fix would be something like: value = self.to_text() if not isinstance(value, unicode): value = value.decode('ascii') return value </pre> </blockquote> </blockquote> <pre wrap=""> thanks for the guidance and comments </pre> <blockquote type="cite"> <pre wrap=""> Most importantly, we should fix/provide this method in python-dns and inherit this method from there. </pre> </blockquote> <pre wrap=""> Well, I made a pr, but apparently travis ci test failed with other versions of python, so it is possible that they do not approve, I will be performing other tests to see what the downside. <a class="moz-txt-link-freetext" href="https://github.com/rthalley/dnspython/pull/195">https://github.com/rthalley/dnspython/pull/195</a> </pre> </blockquote> <pre wrap=""> Looking at the PR, there are functions dns.name.to_text() dns.name.to_unicode() What is missing in them? Petr^2 Spacek </pre> <blockquote type="cite"> <blockquote type="cite"> <blockquote type="cite"> <blockquote type="cite"> <pre wrap="">I will look on this, for some reason we received your e-mail just today (2016-07-26) </pre> </blockquote> </blockquote> </blockquote> <pre wrap=""> welcome. it was my mistake, I sent the patch to the list before being signed to the list </pre> <blockquote type="cite"> <blockquote type="cite"> <pre wrap=""> Honza [1] <a class="moz-txt-link-rfc2396E" href="https://pythonhosted.org/six/#six.u"><https://pythonhosted.org/six/#six.u></a> </pre> </blockquote> </blockquote> </blockquote> <pre wrap="">-- Petr^2 Spacek </pre> </blockquote> <pre wrap=""> Hi. I send the requested changes thanks for review. </pre> <fieldset class="mimeAttachmentHeader"></fieldset> </blockquote> According the <a class="moz-txt-link-freetext" href="https://github.com/rthalley/dnspython/blob/master/dns/name.py#L375">https://github.com/rthalley/dnspython/blob/master/dns/name.py#L375</a> New dnspython always return binary strings, so we should always decode it, because IPA internals need punycoded domain in unicode format IMO this is broken in current dnspython released in Fedora. There are plenty of py3 bugs, we have to provide newer dnspython package to fedora, so this should not be fixed on IPA side. regards Martin </body> </html>