<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<p><br>
</p>
<br>
<div class="moz-cite-prefix">On 02.08.2016 13:22, Florence
Blanc-Renaud wrote:<br>
</div>
<blockquote
cite="mid:ad27b741-389b-f264-9882-d8a1035f3d8f@redhat.com"
type="cite">Hi,
<br>
<br>
please find attached a patch related to 'ipa hbactest' producing a
Traceback.
<br>
<br>
<a class="moz-txt-link-freetext" href="https://fedorahosted.org/freeipa/ticket/6157">https://fedorahosted.org/freeipa/ticket/6157</a>
<br>
<br>
Flo.
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
Hello Flo,<br>
<br>
<br>
1)<br>
can you please move that check, right bellow the for?<br>
<br>
for o in self.output:<br>
+ if o == 'value':<br>
+ continue<br>
<br>
It is peformance improvements :) We should not waste time with
getting values from dict if we will not use them<br>
<br>
2)<br>
elif isinstance(result, (unicode, bool)):<br>
if o == 'summary':<br>
textui.print_summary(result)<br>
else:<br>
textui.print_indented(result)<br>
<br>
Here you should remove the 'bool' from isinstance or update
print_indented to allow work with boolean (I prefer the first one).
Because with any other bool value it will fail again.<br>
<br>
Thanks,<br>
Martin^2<br>
</body>
</html>