<html> <head> <meta content="text/html; charset=windows-1252" http-equiv="Content-Type"> </head> <body bgcolor="#FFFFFF" text="#000000"> <div class="moz-cite-prefix">On 02.08.2016 18:08, Pavel Vomacka wrote: </div> <blockquote cite="mid:ab66b919-51bd-f7dc-68c3-4a1497a11147@redhat.com" type="cite"> On 08/02/2016 05:31 PM, Pavel Vomacka wrote: <blockquote type="cite"> On 08/02/2016 05:27 PM, Martin Basti wrote: <blockquote type="cite"> On 02.08.2016 17:12, Rob Crittenden wrote: <blockquote type="cite">Pavel Vomacka wrote: <blockquote type="cite">Hello, please review attached patches which Split make lint to more targets and add jslint </blockquote> What's the driver to split the checks out into separate targets? </blockquote> It is called several times during build (makes build slower), and you cannot run `make clean` in case you have wrong API.txt, because it will explode </blockquote> Yes, definitely. </blockquote> So I removed moving the aci and api checks and just add jslint. <blockquote type="cite"> <blockquote type="cite"> <blockquote type="cite"> You are moving the makeapi and makeaci from version-update to lint. They were in version-update for a reason: downstream builds do not call lint. Downstream may patch code. API cannot break. </blockquote> Can we update downstream spec then? <blockquote type="cite"> No ticket? </blockquote> Pavel please file tickets. </blockquote> Yes, I will file tickets for these changes. </blockquote> Also ticket is now filed: <a class="moz-txt-link-freetext" href="https://fedorahosted.org/freeipa/ticket/6161">https://fedorahosted.org/freeipa/ticket/6161</a> <blockquote type="cite"> <blockquote type="cite"> <blockquote type="cite"> rob </blockquote> Martin^2 </blockquote> </blockquote> <fieldset class="mimeAttachmentHeader"></fieldset> </blockquote> ACK 0098-2: works for me Martin^2 </body> </html>