<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<p><br>
</p>
<br>
<div class="moz-cite-prefix">On 02.08.2016 14:50, Lenka Doudova
wrote:<br>
</div>
<blockquote
cite="mid:ae3e7c75-ce23-9d12-d7f2-0a68b918d257@redhat.com"
type="cite">
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
<p><br>
</p>
<br>
<div class="moz-cite-prefix">On 07/29/2016 11:43 AM, Lenka Doudova
wrote:<br>
</div>
<blockquote
cite="mid:ee236d88-7d7b-a3ec-c853-db6ef1f3f826@redhat.com"
type="cite">
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
<p><br>
</p>
<br>
<div class="moz-cite-prefix">On 07/29/2016 11:41 AM, Lenka
Doudova wrote:<br>
</div>
<blockquote
cite="mid:b5aca3c1-60a9-d7cb-73a6-8ad924dc7309@redhat.com"
type="cite">
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
<br>
<div class="moz-cite-prefix">On 07/28/2016 01:35 PM, Peter
Lacko wrote:<br>
</div>
<blockquote
cite="mid:529785673.9646711.1469705707399.JavaMail.zimbra@redhat.com"
type="cite">
<pre wrap="">Hops, fixed.
Peter
----- Original Message -----
From: "Lenka Doudova" <a moz-do-not-send="true" class="moz-txt-link-rfc2396E" href="mailto:ldoudova@redhat.com"><ldoudova@redhat.com></a>
To: <a moz-do-not-send="true" class="moz-txt-link-abbreviated" href="mailto:freeipa-devel@redhat.com">freeipa-devel@redhat.com</a>
Sent: Thursday, July 28, 2016 1:32:25 PM
Subject: Re: [Freeipa-devel] [PATCH 0003] Test validity of URIs in certificate
Hi,
I cannot find any attached patch :)
Lenka
On 07/28/2016 01:30 PM, Peter Lacko wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Attached you can find a patch adding test for URIs in generated certificate
ipatests/test_xmlrpc/test_cert_plugin.py
Since I'm leaving Red Hat in end of July, I won't be able to modify this patch anymore.
Regards,
Peter
</pre>
</blockquote>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
Hi,<br>
<br>
NACK. Code looks fine and works well on master branch, but
patch does not apply on 4-3 and 4-2 branches.<br>
Peter left the company but claimed he can fix the patch if
necessary, I'll communicate it with him or fix it myself.<br>
<br>
Lenka<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
Oh, and forgot this one - PEP8 error:<br>
./ipatests/test_xmlrpc/test_cert_plugin.py:191:80: E501 line too
long (105 > 79 characters)<br>
<br>
Lenka<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
Hi,<br>
<br>
since Peter has quit already, I took it upon myself to do minor
fix and rebase to the patch.<br>
1) i removed pylint disable comments from the patch, as they were
unnecessary (this also solved PEP8 error)<br>
2) I rebased the patch to be applicable for ipa-4-3 branch.<br>
Original functionality of the patch remains unchanged.<br>
<br>
Both fixed patches attached.<br>
<br>
Lenka<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
<br>
Hello,<br>
<br>
1)<br>
This is not needed<br>
<pre wrap="">+ global sn
+
+ result = api.Command.cert_show(sn, out=unicode(self.certfile))
you need the global statement only for write access. But sn is not assigned in this code block.
2)
I prefer to use instance attributes (self.sn) instead of global variables
Martin^2
</pre>
</body>
</html>