<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<br>
<br>
<div class="moz-cite-prefix">On 08/05/2016 02:16 PM, Lukas Slebodnik
wrote:<br>
</div>
<blockquote cite="mid:20160805121651.GH6891@10.4.128.1" type="cite">
<pre wrap="">ehlo,
attached patches fixes few compiler warnings in ipa-extop.
Sorry for not following naming convention for patches.
But I do not remeber my numer and you will use github/pagure
anyway.
LS
</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
Hi Lukas,<br>
<br>
0001-ipa_pwd_extop-Fix-warning-decalration-shadows-previo.patch
looks ok but there is a leak in the remaining code.<br>
In fact bind_sdn and target_sdn need to be freed
(slapi_sdn_free(&xxx)) before the end of the 'if (dn)'
statement.<br>
Do you want to fix it in your patch of should we use an other patch
?<br>
<br>
<br>
0002-ipa-pwd-extop-Fix-warning-assignment-discards-const-.patch is
ok. Ack<br>
<br>
thanks<br>
thierry<br>
</body>
</html>