<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<p><br>
</p>
<br>
<div class="moz-cite-prefix">On 05.08.2016 16:44, Martin Basti
wrote:<br>
</div>
<blockquote
cite="mid:9001af3d-2831-6c3c-141d-941656bcbe94@redhat.com"
type="cite">
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
<p><br>
</p>
<br>
<div class="moz-cite-prefix">On 02.08.2016 18:08, Pavel Vomacka
wrote:<br>
</div>
<blockquote
cite="mid:ab66b919-51bd-f7dc-68c3-4a1497a11147@redhat.com"
type="cite"> <br>
On 08/02/2016 05:31 PM, Pavel Vomacka wrote: <br>
<blockquote type="cite"> <br>
<br>
On 08/02/2016 05:27 PM, Martin Basti wrote: <br>
<blockquote type="cite"> <br>
<br>
On 02.08.2016 17:12, Rob Crittenden wrote: <br>
<blockquote type="cite">Pavel Vomacka wrote: <br>
<blockquote type="cite">Hello, <br>
<br>
please review attached patches which Split make lint to
more targets and <br>
add jslint <br>
</blockquote>
<br>
What's the driver to split the checks out into separate
targets? <br>
</blockquote>
<br>
It is called several times during build (makes build
slower), and you cannot run `make clean` in case you have
wrong API.txt, because it will explode <br>
</blockquote>
Yes, definitely. <br>
</blockquote>
So I removed moving the aci and api checks and just add jslint.
<br>
<blockquote type="cite">
<blockquote type="cite">
<blockquote type="cite"> <br>
You are moving the makeapi and makeaci from version-update
to lint. They were in version-update for a reason:
downstream builds do not call lint. Downstream may patch
code. API cannot break. <br>
</blockquote>
Can we update downstream spec then? <br>
<br>
<blockquote type="cite"> <br>
No ticket? <br>
</blockquote>
Pavel please file tickets. <br>
<br>
</blockquote>
Yes, I will file tickets for these changes. <br>
</blockquote>
Also ticket is now filed: <br>
<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://fedorahosted.org/freeipa/ticket/6161">https://fedorahosted.org/freeipa/ticket/6161</a>
<br>
<blockquote type="cite">
<blockquote type="cite">
<blockquote type="cite"> <br>
rob <br>
<br>
</blockquote>
Martin^2 <br>
<br>
</blockquote>
<br>
</blockquote>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
<br>
ACK 0098-2: works for me<br>
<br>
Martin^2<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
Pushed to master: 58da5fb4b9e81e872e0b59c17263071f8b2889da<br>
<br>
</body>
</html>