<div dir="ltr"><div>Hi,<br><br>I have edited my previous patch.<br><br><div class="gmail_quote">On Thu, Aug 11, 2016 at 11:52 AM, Jan Cholasta <span dir="ltr"><<a href="mailto:jcholast@redhat.com" target="_blank">jcholast@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi,<span class=""><br>
<br>
On 11.8.2016 09:55, Tibor Dudlak wrote:<br>
</span><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="">
Hi,<br>
<br>...</span><br>
</blockquote>
<br>
+class login_x509(login_kerberos, KerberosSession, HTTP_Status):<br>
+    key = '/session/login_x509'<br>
<br>
login_kerberos already subclasses KerberosSession and HTTP_Status, no 
need to do it again here. In fact, it would be best to split off the 
bussiness logic from login_kerberos into a separate class and inherit 
both login_kerberos and login_x509 from it:<br>
<br>
    class KerberosLogin(Backend, KerberosSession, HTTP_Status):<br>
        def _on_finalize(self):<br>
            ...<br>
<br>
        def __call__(self, ...):<br>
            ...<br>
<br>
    class login_kerberos(KerberosLogin):<br>
        key = '/session/login_kerberos'<br>
<br>
    class login_x509(KerberosLogin):<br>
        key = '/session/login_x509'<br>
<br>
Honza<span class=""><font color="#888888"><br>
<br>
-- <br>
Jan Cholasta<br>
</font></span></blockquote></div><br></div>Thank jcholast for review, it should be all right now.<br><div><div><br>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div>Tibor Dudlák<br></div>Intern - Identity management Special Projects<br></div>Red Hat<br><div><span><font color="#888888"></font></span></div></div></div>
</div></div></div>