<html> <head> <meta content="text/html; charset=windows-1252" http-equiv="Content-Type"> </head> <body bgcolor="#FFFFFF" text="#000000"> <tt>Seems like a good idea, I'm attaching the updated patch. Autofill does work when the param is required. </tt> <tt> </tt> <div class="moz-cite-prefix"><tt>On 08/19/2016 04:19 PM, Martin Basti wrote:</tt><tt> </tt></div> <blockquote cite="mid:ba5f5348-0106-f45e-2c2b-5a048e4e1634@redhat.com" type="cite"> <meta content="text/html; charset=windows-1252" http-equiv="Content-Type"> <tt> </tt> <tt> </tt> <div class="moz-cite-prefix"><tt>On 16.08.2016 17:35, Tomas Krizek wrote:</tt><tt> </tt> </div> <blockquote cite="mid:e7efe1ef-fbfa-7c26-b02e-c2e9e62ed2a4@redhat.com" type="cite"><tt>Hi, </tt><tt> </tt> <tt> </tt><tt> the attached patch fixes an error message when user provides an empty key while adding otp token. </tt><tt> </tt> <tt> </tt> <tt><a moz-do-not-send="true" class="moz-txt-link-freetext" href="https://fedorahosted.org/freeipa/ticket/6200">https://fedorahosted.org/freeipa/ticket/6200</a></tt><tt> </tt><tt> </tt> <tt> </tt> <tt> </tt> <fieldset class="mimeAttachmentHeader"></fieldset> <tt> </tt> </blockquote> <tt> </tt><tt> I'm curious why we don't fix it here:</tt><tt> </tt> <tt> </tt><tt> OTPTokenKey('ipatokenotpkey?',</tt><tt> </tt><tt> cli_name='key',</tt><tt> </tt><tt> label=_('Key'),</tt><tt> </tt><tt> doc=_('Token secret (Base32; default: random)'),</tt><tt> </tt><tt> default_from=lambda: os.urandom(KEY_LENGTH),</tt><tt> </tt><tt> autofill=True,</tt><tt> </tt><tt> flags=('no_display', 'no_update', 'no_search'),</tt><tt> </tt><tt> ),</tt><tt> </tt> <tt> </tt> <tt> </tt><tt> If OTPTokenKey is mandratory, it should be required param (autofill should work in this case too)</tt><tt> </tt> <tt> </tt><tt> Martin^2</tt><tt> </tt> </blockquote> <tt> </tt> <pre class="moz-signature" cols="72">-- Tomas Krizek</pre> </body> </html>