<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<tt>Fixed the typo in error message.<br>
</tt><tt><br>
</tt>
<div class="moz-cite-prefix"><tt>On 08/23/2016 12:15 PM, Tomas
Krizek wrote:</tt><tt><br>
</tt></div>
<blockquote
cite="mid:ca829173-1f56-09c4-0684-0b26b1db340f@redhat.com"
type="cite"><tt>In that case, the first version of the patch
solves the issue.
</tt><tt><br>
</tt>
<tt><br>
</tt><tt>I'm attaching the patch once again, but it's the same as
the one in the original message.
</tt><tt><br>
</tt>
<tt><br>
</tt>
<tt><br>
</tt><tt>On 08/23/2016 11:53 AM, Jan Cholasta wrote:
</tt><tt><br>
</tt>
<blockquote type="cite"><tt>On 22.8.2016 19:08, Tomas Krizek
wrote:
</tt><tt><br>
</tt>
<blockquote type="cite"><tt>I've attached the updated patch.
Hopefully I didn't forget anything else
</tt><tt><br>
</tt><tt>this time.
</tt><tt><br>
</tt>
<tt><br>
</tt>
<tt><br>
</tt><tt>On 08/22/2016 05:48 PM, Martin Basti wrote:
</tt><tt><br>
</tt>
<blockquote type="cite">
<tt><br>
</tt><tt>On 22.08.2016 10:22, Tomas Krizek wrote:
</tt><tt><br>
</tt>
<blockquote type="cite">
<tt><br>
</tt><tt>Seems like a good idea, I'm attaching the updated
patch. Autofill
</tt><tt><br>
</tt><tt>does work when the param is required.
</tt><tt><br>
</tt>
<tt><br>
</tt>
<tt><br>
</tt><tt>On 08/19/2016 04:19 PM, Martin Basti wrote:
</tt><tt><br>
</tt>
<blockquote type="cite">
<tt><br>
</tt>
<tt><br>
</tt>
<tt><br>
</tt><tt>On 16.08.2016 17:35, Tomas Krizek wrote:
</tt><tt><br>
</tt>
<blockquote type="cite"><tt>Hi,
</tt><tt><br>
</tt>
<tt><br>
</tt><tt>the attached patch fixes an error message
when user provides an
</tt><tt><br>
</tt><tt>empty key while adding otp token.
</tt><tt><br>
</tt>
<tt><br>
</tt><tt><a class="moz-txt-link-freetext" href="https://fedorahosted.org/freeipa/ticket/6200">https://fedorahosted.org/freeipa/ticket/6200</a>
</tt><tt><br>
</tt>
<tt><br>
</tt>
<tt><br>
</tt>
<tt><br>
</tt></blockquote>
<tt><br>
</tt><tt>I'm curious why we don't fix it here:
</tt><tt><br>
</tt>
<tt><br>
</tt><tt> OTPTokenKey('ipatokenotpkey?',
</tt><tt><br>
</tt><tt> cli_name='key',
</tt><tt><br>
</tt><tt> label=_('Key'),
</tt><tt><br>
</tt><tt> doc=_('Token secret (Base32;
default: random)'),
</tt><tt><br>
</tt><tt> default_from=lambda:
os.urandom(KEY_LENGTH),
</tt><tt><br>
</tt><tt> autofill=True,
</tt><tt><br>
</tt><tt> flags=('no_display', 'no_update',
'no_search'),
</tt><tt><br>
</tt><tt> ),
</tt><tt><br>
</tt>
<tt><br>
</tt>
<tt><br>
</tt><tt>If OTPTokenKey is mandratory, it should be
required param (autofill
</tt><tt><br>
</tt><tt>should work in this case too)
</tt><tt><br>
</tt>
<tt><br>
</tt><tt>Martin^2
</tt><tt><br>
</tt></blockquote>
<tt><br>
</tt><tt>-- </tt><tt><br>
</tt><tt>Tomas Krizek
</tt><tt><br>
</tt></blockquote>
<tt><br>
</tt><tt>You changed API, you must regenerate API.txt
(./makeapi) and increment
</tt><tt><br>
</tt><tt>minor version in VERSION file
</tt><tt><br>
</tt>
<tt><br>
</tt><tt>Option 'ipatokenotpkey?' in command
'otptoken_add/1' in API file not found
</tt><tt><br>
</tt><tt>Options count in otptoken_add of 22 doesn't match
expected: 23
</tt><tt><br>
</tt><tt>Option ipatokenotpkey of command otptoken_add in
ipalib, not in API file:
</tt><tt><br>
</tt><tt>OTPTokenKey('ipatokenotpkey', autofill=True,
cli_name='key')
</tt><tt><br>
</tt></blockquote>
</blockquote>
<tt><br>
</tt><tt>NACK, this is a backward incompatible change.
</tt><tt><br>
</tt>
<tt><br>
</tt><tt>AFAICT the option should remain optional, see the doc
string:
</tt><tt><br>
</tt>
<tt><br>
</tt><tt> Token secret (Base32; default: random)
</tt><tt><br>
</tt><tt> ^^^^^^^^^^^^^^^
</tt><tt><br>
</tt>
<tt><br>
</tt></blockquote>
<tt><br>
</tt><tt><br>
</tt>
<fieldset class="mimeAttachmentHeader"></fieldset>
<tt><br>
</tt>
</blockquote>
<tt><br>
</tt>
<pre class="moz-signature" cols="72">--
Tomas Krizek</pre>
</body>
</html>