<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"> <html> <head> <meta content="text/html; charset=ISO-8859-1" http-equiv="Content-Type"> <title></title> </head> <body bgcolor="#ffffff" text="#000000"> On 08/23/2011 07:58 AM, Ivan Nečas wrote: <blockquote cite="mid:4E5395E7.3070906@redhat.com" type="cite">Hello On 08/19/2011 09:25 PM, Partha Aji wrote: <blockquote type="cite">Issue: At the end of our roles-ui rewrite, we realized that we need to add rules to navigation.rb to acl things off. So based on rules in the controllers I came up with the following rules based navigation rb. <a class="moz-txt-link-freetext" href="http://git.fedorahosted.org/git/?p=katello.git;a=blob;f=src/config/navigation.rb;h=5d48039d1ce90cacf1f5b0e936715ff5f3adefff;hb=bea1d8c6d253cb79430586c5f92c4bc8ead6e9b9">http://git.fedorahosted.org/git/?p=katello.git;a=blob;f=src/config/navigation.rb;h=5d48039d1ce90cacf1f5b0e936715ff5f3adefff;hb=bea1d8c6d253cb79430586c5f92c4bc8ead6e9b9</a> I notice a couple of problems here and need suggestions on way to refactor this. 1) Rules are on every line causing confusion and ugliness. For example providers_sub.item :edit, _("Basics"), (@provider.nil? || @provider.new_record?) ? "" : edit_provider_path(@provider.id), :class => 'navigation_element', :if => Proc.new { !@provider.nil?&& @provider.readable?&& !@provider.new_record? } </blockquote> How about using rules we've defined in the controller, so instead of the Proc.new there would be something like ProvidersController.rules_for(:index). </blockquote> <a data-display-url="pic.twitter.com/dlDa9oD" href="http://t.co/dlDa9oD" data-expanded-url="http://twitter.com/OnLive/status/106065819099873281/photo/1" title="http://twitter.com/OnLive/status/106065819099873281/photo/1" target="" rel="nofollow" class="twitter-timeline-link" data-twitter-media-url="true"></a> Would this work properly since in many cases the rules rely on specific instance variables? <blockquote cite="mid:4E5395E7.3070906@redhat.com" type="cite"> <blockquote type="cite"> 2) The top level block always needs to know if the bottom level ones are going to all be hidden so that it can hide itself. For example look at Content management top_level.item :content, _("Content Management"),<snip> do |content_sub| content_sub.item :providers,<snip> do |providers_sub| providers_sub.item :edit, _("Basics"),<snip> :if => Proc.new { !@provider.nil?&& @provider.readable?&& !@provider.new_record? } <snip> end if Provider.any_readable?(current_organization) <snip> content_sub.item :promotions,<snip> do |package_sub| <snip> end if current_organization.readable_for_promotions? content_sub.item(:changeset,<snip> if current_organization.any_changesets_readable? end if current_organization()&& (Provider.any_readable?(current_organization)|| current_organization.readable_for_promotions?&& current_organization.any_changesets_readable?) #end content notice that the last condition has to include the rules for the sub items again to not show up. I was not sure what a good way to refactor this would be so as to make this file a little more readable. I started with an idea of creating a navigation_rules, that would embed the rules and some how we have line refer to that rules file and figure out. Any suggestions. May be there is some ruby magic that will make this file totally readable :).. Or may be its perfect as it is now. </blockquote> Maybe using custom renderer for navigation, that would check, whether an item has some visible children. There should be some info on renderers in the wiki for simple-navigation. github.com/andi/simple-navigation/wiki/Registering-Renderers I think it's worth of refactoring since there are those duplications. -- Ivan <blockquote type="cite"> Partha _______________________________________________ katello-devel mailing list <a class="moz-txt-link-abbreviated" href="mailto:katello-devel@redhat.com">katello-devel@redhat.com</a> <a class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/katello-devel">https://www.redhat.com/mailman/listinfo/katello-devel</a> </blockquote> </blockquote> </body> </html>