[Libguestfs] [PATCH nbdkit 2/2] common/include/checked-overflow.h: Provide fallback

[Richard W.M. Jones]

On Tue, Nov 23, 2021 at 04:19:08PM +0100, Laszlo Ersek wrote:
> On 11/23/21 11:44, Laszlo Ersek wrote:
> > So: the fallbacks need to be available (= built) in the source code
> > unconditionally, so they can be directly called by the test suite. The
> > actual "falling back" to them must be separate. Is that what you mean?
> 
> ... should this go into common/replacements, or common/utils? The former
> seems like a better fit.

common/replacements is currently used to replace functions which are
missing on Windows.  Maybe this could be extended for RHEL 7?

Probably easier to put it in common/utils/checked-overflow.h TBH (see
my original version of the patch which did that and used a configure
check to select which version is used).

> On the other hand, libnbd (assuming we'll want
> to port the same to libnbd) does not have common/replacements at all...

Indeed, and libnbd is never likely to get a Windows port.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.
http://fedoraproject.org/wiki/MinGW