[Libguestfs] [PATCH 3/3] build, docs: spell out minimum version (4.0.0) for the (optional) Yara lib

[Eric Blake]

On Wed, Oct 13, 2021 at 03:36:11PM +0200, Laszlo Ersek wrote:
> Commit e597fc5317e0 ("daemon/yara: fix undefined behavior due to Yara 4.0
> API changes", 2021-10-12) prevents the daemon from using such a Yara
> version that precedes 4.0.0.
> 
> If only yara < 4 is found, treat the library as absent, rather than
> attempting and failing to compile the yara module of the daemon. Note the
> version requirement in the documentation too.
> 
> Suggested-by: Eric Blake <eblake at redhat.com>
> Suggested-by: Richard W.M. Jones <rjones at redhat.com>
> Signed-off-by: Laszlo Ersek <lersek at redhat.com>
> ---
>  docs/guestfs-building.pod | 2 +-
>  m4/guestfs-daemon.m4      | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/docs/guestfs-building.pod b/docs/guestfs-building.pod
> index 1f872700e367..803b89fd5ea6 100644
> --- a/docs/guestfs-building.pod
> +++ b/docs/guestfs-building.pod

Aha, that's the file I missed in my earlier review when I checked only
README and HACKING.  And HACKING even mentions guestfs-building(1)
(which is what gets compiled from this file).

ACK series from my point of view.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org