[Libguestfs] [PATCH v2v 0/2] output: Remove -o json mode [in stages]

Laszlo Ersek lersek at redhat.com
Mon Apr 11 10:34:30 UTC 2022


On 04/11/22 12:11, Richard W.M. Jones wrote:
> I'd like to remove the unused -o json mode.  The implementation is
> over-complicated and the only potential user (KubeVirt) isn't using it
> now and would be better off with a proper -o kubevirt mode, which I'm
> going to implement later.
> 
> My plan would be to add the patches in two stages.  The first patch,
> which only removes the documentation but leaves the feature and test,
> would be applied to stable branch virt-v2v 2.0.  The second patch
> would be go on the development branch 2.1 (which hasn't yet been
> created).  The first stable release without this feature would be 2.2.

If the second patch goes on the 2.1 dev branch, then why wouldn't the
2.1 release include it? (IOW the 2.1 release would not have "-o json"
any more.)

I'm OK with the plan just don't understand how 2.2 is relevant.

> For RHEL I'd probably put both patches in 9.1, even though we're
> planning to ship virt-v2v 2.0.x there.  It means there will be an
> option/feature present in RHEL 9.0 which is removed in 9.1.

I don't think "-o json" is used by anyone at the moment, so in practice
it shouldn't become a regression.

I'll look at the patches now.

Thanks
Laszlo


More information about the Libguestfs mailing list