[Libguestfs] [PATCH v2v 0/2] output: Remove -o json mode [in stages]

Richard W.M. Jones rjones at redhat.com
Mon Apr 11 10:40:25 UTC 2022


On Mon, Apr 11, 2022 at 12:37:03PM +0200, Laszlo Ersek wrote:
> On 04/11/22 12:34, Laszlo Ersek wrote:
> > On 04/11/22 12:11, Richard W.M. Jones wrote:
> >> I'd like to remove the unused -o json mode.  The implementation is
> >> over-complicated and the only potential user (KubeVirt) isn't using it
> >> now and would be better off with a proper -o kubevirt mode, which I'm
> >> going to implement later.
> >>
> >> My plan would be to add the patches in two stages.  The first patch,
> >> which only removes the documentation but leaves the feature and test,
> >> would be applied to stable branch virt-v2v 2.0.  The second patch
> >> would be go on the development branch 2.1 (which hasn't yet been
> >> created).  The first stable release without this feature would be 2.2.
> > 
> > If the second patch goes on the 2.1 dev branch, then why wouldn't the
> > 2.1 release include it? (IOW the 2.1 release would not have "-o json"
> > any more.)
> > 
> > I'm OK with the plan just don't understand how 2.2 is relevant.
> 
> Ah, having read the first commit message, I think the typo could be the
> other way around: you may have meant the 2.2 dev branch (which doesn't
> yet exist because there hasn't been a 2.1 release yet). The 2.1 dev
> branch is already open OTOH, IIUC.

Up to 2.0.2 I was merging the changes from master to stable-2.0, but
commit 75872bf28 adds a new feature so that's where the two branches
split.

stable-2.0 => stable virt-v2v 2.0
master => development virt-v2v 2.1

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-top is 'top' for virtual machines.  Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://people.redhat.com/~rjones/virt-top


More information about the Libguestfs mailing list