[Libguestfs] [v2v PATCH] output_qemu: pass "=on" with "readonly" to "-drive"

[Richard W.M. Jones]

On Mon, May 09, 2022 at 10:27:11AM +0200, Laszlo Ersek wrote:
> > qemu-system-x86_64: -drive
> > if=pflash,format=raw,file=/usr/share/OVMF/OVMF_CODE.fd,readonly: warning:
> > short-form boolean option 'readonly' deprecated
> > Please use readonly=on instead
> 
> Reported-by: Ming Xie <mxie at redhat.com>
> Signed-off-by: Laszlo Ersek <lersek at redhat.com>
> ---
>  output/output_qemu.ml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/output/output_qemu.ml b/output/output_qemu.ml
> index 29adcba901a3..3269fba501e4 100644
> --- a/output/output_qemu.ml
> +++ b/output/output_qemu.ml
> @@ -164,7 +164,7 @@ module QEMU = struct
>            arg_list "-global"
>              ["driver=cfi.pflash01"; "property=secure"; "value=on"];
>          arg_list "-drive"
> -          ["if=pflash"; "format=raw"; "file=" ^ code; "readonly"];
> +          ["if=pflash"; "format=raw"; "file=" ^ code; "readonly=on"];
>          arg_noquote "-drive" "if=pflash,format=raw,file=\"$uefi_vars\"";
>      );

ACK

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.
http://libguestfs.org/virt-v2v