[Libguestfs] [PATCH v2v] convert: Ignore /dev/mapper/osprober-* devices when trimming

[Richard W.M. Jones]

On Tue, May 17, 2022 at 12:29:23PM +0200, Laszlo Ersek wrote:
> On 05/17/22 11:48, Laszlo Ersek wrote:
> 
> > Do you think it's feasible to *move* the name-based filtering from
> > virt-v2v's do_fstrim to the libguestfs daemon's list-filesystems API
> > implementation? I can't see a reason why the list-filesystems API should
> > *ever* return these /dev/mapper/osprober-* nodes.
> > 
> > IOW all I'm proposing is that we move the same workaround deeper in the
> > stack.
> 
> Scratch that -- that still allows the grub2/osprober bug to spread too far.
> 
> Once we get some info from the rhboot team on the nature of this
> grub2/osprober bug, can we perhaps unmount and "dmsetup remove" these
> /dev/mapper/osprober-* block devices, in v2v, right after we call
> "grub2_mkconfig_cmd"? That would contain this issue tightly.

I'll will test out this idea and add a comment to the BZ
(https://bugzilla.redhat.com/show_bug.cgi?id=2003503).

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.
http://libguestfs.org/virt-v2v