[Libguestfs] [libnbd PATCH 1/2] ci: Add opensuse-leap 15.4, skip TLS on 15.3

[Daniel P. Berrangé]

On Wed, Oct 19, 2022 at 09:46:12AM -0500, Eric Blake wrote:
> lcitool recently added support for Leap 15.4; meanwhile, Leap 15.3 has
> a version of nbdkit that tries to use @NBDKIT,SYSTEM as the TLS
> priority which then crashes in gnutls.  Explicitly testing our
> --without-gnutls configure coverage on that platform is thus a good
> idea; this required tweaking build.sh to learn another variables, and
> reordering to put CONFIGURE_OPTS (which the user can override at
> pipeline time) after our hard-coded CONFIG_ARGS.

Since you added support for $GNUTLS instead of setting CONFIGURE_OPTS
in manifest.yml, there was no need for the re-ordering of that
line. Still I guess the new order makes sense, as it allows override
of stuff set by CONFIG_ARGS should it be needed in future.

> 
> Thanks: Daniel P. Berrangé <berrange at redhat.com>
> ---
>  ci/build.sh                                | 14 +++--
>  ci/buildenv/opensuse-leap-154.sh           | 61 +++++++++++++++++++++
>  ci/containers/opensuse-leap-154.Dockerfile | 62 ++++++++++++++++++++++
>  ci/gitlab.yml                              |  1 +
>  ci/gitlab/build-templates.yml              |  5 ++
>  ci/gitlab/builds.yml                       | 20 +++++++
>  ci/gitlab/container-templates.yml          |  1 +
>  ci/gitlab/containers.yml                   |  7 +++
>  ci/manifest.yml                            | 10 +++-
>  9 files changed, 176 insertions(+), 5 deletions(-)
>  create mode 100644 ci/buildenv/opensuse-leap-154.sh
>  create mode 100644 ci/containers/opensuse-leap-154.Dockerfile

Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|