[Libguestfs] [libnbd PATCH] RFC: api: Add nbd_supports_vsock()

Laszlo Ersek lersek at redhat.com
Fri Sep 2 07:36:49 UTC 2022


On 09/02/22 01:35, Eric Blake wrote:
> On Thu, Sep 01, 2022 at 05:33:43PM +0100, Richard W.M. Jones wrote:
>>> How about the following wording:
>>>
>>> Returns true if libnbd was compiled with support for the C<AF_VSOCK>
>>> family of sockets, or false if not.  Note that on the Linux
>>> operating system, this returns true if there is compile-time
>>> support, but you may still need runtime support for some aspects
>>> of AF_VSOCK usage; for example, use of C<VMADDR_CID_LOCAL> as the
>>> server name requires that the I<vsock_loopback> kernel module is
>>> loaded.
>>
>> You can use paragraphs (and even subheadings) in the POD
>> here if you want.
>>
>> Anyway, looks good with the enhanced documentation so:
>>
>> Reviewed-by: Richard W.M. Jones <rjones at redhat.com>
> 
> Now in as commit f8b2b4fc
> 

Thanks, looks good!

Laszlo


More information about the Libguestfs mailing list