[Libguestfs] [p2v PATCH 13/15] create_conversion_dialog(): make "start_button" local

Laszlo Ersek lersek at redhat.com
Mon Sep 19 13:35:09 UTC 2022


The "start_button" variable for the corresponding widget in the Conversion
dialog need not be global; it is only used temporarily, while we connect
the dialog's "Start" response to start_conversion_clicked(). Make it
local. No functional changes.

Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2124538
Signed-off-by: Laszlo Ersek <lersek at redhat.com>
---
 gui.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/gui.c b/gui.c
index 88ea648cdca9..f7b7ab25adaa 100644
--- a/gui.c
+++ b/gui.c
@@ -127,8 +127,7 @@ static GtkWidget *conv_dlg,
   *vcpus_warning, *memory_warning, *target_warning_label,
   *o_combo, *oc_entry, *os_entry, *of_entry, *oa_combo,
   *info_label,
-  *disks_list, *removable_list, *interfaces_list,
-  *start_button;
+  *disks_list, *removable_list, *interfaces_list;
 static int vcpus_entry_when_last_sensitive;
 
 /* The running dialog which is displayed when virt-v2v is running. */
@@ -742,7 +741,7 @@ create_conversion_dialog (struct config *config,
                           const char * const *disks,
                           const char * const *removable)
 {
-  GtkWidget *back;
+  GtkWidget *back, *start_button;
   GtkWidget *hbox, *left_vbox, *right_vbox;
   GtkWidget *target_frame, *target_vbox, *target_tbl;
   GtkWidget *guestname_label, *vcpus_label, *memory_label;



More information about the Libguestfs mailing list