[Libguestfs] [p2v PATCH 15/15] virt-p2v.pod: explain how to bring iSCSI LUNs to the disk selection dialog

Richard W.M. Jones rjones at redhat.com
Fri Sep 23 09:54:10 UTC 2022


ACK series, but see my comment about patch 14.

A couple of other general points:

(1) You could copy the vector type from nbdkit if that would help with
handling lists of strings.

(2) Should we drop Gtk2 support?  I kept this around to allow virt-p2v
to be compiled on RHEL <= 6.  RHEL 5 in particular needs Gtk 2.10,
which even for Gtk 2 is an old version.  Those RHEL releases had
support for some old hardware, especially some old HP Smart Array
devices, which was dropped in newer RHEL, making it impossible to
convert physical machines using those devices.

However the move to PCRE2 means that we can no longer compile on RHEL 6
(RHEL 7 is still OK).  Gtk2 itself went out of support in 2021 [0],
although that is not very relevant.

If we had a customer who wanted support for the old devices, perhaps
it is better to look for a modern distro that still supports them and
would have Gtk 3, PCRE 2, etc.  Perhaps Fedora or Debian.

Rich.

[0] https://blog.gtk.org/2020/12/16/gtk-4-0/

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-builder quickly builds VMs from scratch
http://libguestfs.org/virt-builder.1.html


More information about the Libguestfs mailing list