[Libguestfs] [p2v PATCH 7/7] gui.c: annotate GTK_INPUT_PURPOSE_PASSWORD with upstream GTK3 version
Richard W.M. Jones
rjones at redhat.com
Mon Sep 26 11:59:21 UTC 2022
Apart from Dan's suggestions in patch 1, the series looks good to me.
FWIW RHEL 7 (the earliest distro with PCRE 2) has glib2 2.56.1 &
gtk3 3.22.30, so supporting any earlier versions also seems pointless,
so that might be another thing to review. We could make USE_POPOVERS
unconditional, and make gui-gtk3-compat.h considerably less
complicated.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.
http://fedoraproject.org/wiki/MinGW
More information about the Libguestfs
mailing list