[Libguestfs] [p2v PATCH 1/2] Makefile.am: rectify target dependencies on package dependency files

Laszlo Ersek lersek at redhat.com
Fri Sep 30 14:52:51 UTC 2022


The targets whose recipes invoke "virt-p2v-make-disk" should depend on
"$(dependencies_files)", and not "dependencies.m4". The reason is that
"virt-p2v-make-disk" consumes the filtered / processed files, not the
original dependency list. We have a separate rule that invokes m4 for
generating "$(dependencies_files)" from "dependencies.m4"; we need to loop
that in, so that "virt-p2v-make-disk" see up-to-date filtered files.

Signed-off-by: Laszlo Ersek <lersek at redhat.com>
---
 Makefile.am | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Makefile.am b/Makefile.am
index 02ff1bb2eebd..2881fc947b24 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -328,7 +328,7 @@ $(BLANK_DISK):
 	$(top_builddir)/run guestfish -N $@=part exit
 
 virt-p2v.img: \
-	    dependencies.m4 \
+	    $(dependencies_files) \
 	    issue \
 	    launch-virt-p2v \
 	    p2v.service \
@@ -373,7 +373,7 @@ stamp-test-virt-p2v-pxe-data-files: \
 	touch $@
 
 test-virt-p2v-pxe.img: \
-	    dependencies.m4 \
+	    $(dependencies_files) \
 	    issue \
 	    launch-virt-p2v \
 	    p2v.service \



More information about the Libguestfs mailing list