[Libguestfs] [libnbd PATCH 4/4] copy: rewrap error message about stuck NBD server

Richard W.M. Jones rjones at redhat.com
Fri Apr 14 08:13:16 UTC 2023


On Fri, Apr 14, 2023 at 09:59:56AM +0200, Laszlo Ersek wrote:
> Wrap "copy/nbd-ops.c" at 80 characters.
> 
> I couldn't find a way to test that this change is unobservable.
> 
> Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2172516
> Signed-off-by: Laszlo Ersek <lersek at redhat.com>
> ---
>  copy/nbd-ops.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/copy/nbd-ops.c b/copy/nbd-ops.c
> index d3e50864125f..843b7c1746e3 100644
> --- a/copy/nbd-ops.c
> +++ b/copy/nbd-ops.c
> @@ -482,7 +482,10 @@ nbd_ops_get_extents (struct rw *rw, size_t index,
>  
>      /* The server should always make progress. */
>      if (offset == old_offset) {
> -      fprintf (stderr, "%s: NBD server is broken: it is not returning extent information.\nTry nbdcopy --no-extents as a workaround.\n",
> +      fprintf (stderr,
> +               "%s: NBD server is broken: it is not returning extent "
> +               "information.\n"
> +               "Try nbdcopy --no-extents as a workaround.\n",
>                 rw->name);
>        exit (EXIT_FAILURE);
>      }

Series seems fine, so ACK.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://libguestfs.org


More information about the Libguestfs mailing list