[Libguestfs] [PATCH libnbd] generator: Pass LISTEN_FDNAMES=nbd with systemd socket activation

Daniel P. Berrangé berrange at redhat.com
Tue Feb 7 09:01:19 UTC 2023


On Tue, Feb 07, 2023 at 08:56:11AM +0000, Richard W.M. Jones wrote:
> 
> We worried about getenv's safety (lack of) for quite a while when we
> were writing libguestfs, which uses a lot more environment variables
> in many more places.  But we decided there was simply nothing we could
> do about it, and it was easier not to worry :-)

No one in their right mind will call setenv() after creating threads, and
if they do they deserve any breakage that happens :-) IMHO it is totally
reasonable to rely on getenv() being invariant, and declare any issues to
be someone else's problem to fix.

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|


More information about the Libguestfs mailing list