[Libguestfs] [libnbd PATCH 0/2] Fix docs and testing of completion callback

Eric Blake eblake at redhat.com
Thu Jul 13 19:29:31 UTC 2023


This is my proposal for fixing the documentation to match practice
(namely, that completion.callback is not invoked in the cases where
the aio call itself reports errors); we could instead try to go the
other direction and tweak the generator to guarantee that both
completion.callback and completion.free are reached no matter what,
but that felt more invasive to me.

Eric Blake (2):
  api: Tighten rules on completion.callback
  tests: Add coverage of nbd_aio_opt_* in wrong state

 docs/libnbd.pod                    |  26 +++--
 lib/handle.c                       |   3 +
 lib/opt.c                          |   2 +
 tests/Makefile.am                  |   5 +
 tests/closure-lifetimes.c          |  14 +++
 tests/errors-not-negotiating-aio.c | 170 +++++++++++++++++++++++++++++
 .gitignore                         |   1 +
 7 files changed, 211 insertions(+), 10 deletions(-)
 create mode 100644 tests/errors-not-negotiating-aio.c

-- 
2.41.0



More information about the Libguestfs mailing list