[Libguestfs] [v2v PATCH v2 1/3] lib/utils: fix typo

Richard W.M. Jones rjones at redhat.com
Thu Jun 29 12:55:23 UTC 2023


On Thu, Jun 29, 2023 at 02:34:41PM +0200, Laszlo Ersek wrote:
> Fix a small comment typo from commit 4e7f20684373 ("lib: Improve security
> of in/out sockets when running virt-v2v as root", 2022-03-23).
> 
> Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2182024
> Signed-off-by: Laszlo Ersek <lersek at redhat.com>
> ---
> 
> Notes:
>     v2:
>     
>     - new patch
> 
>  lib/utils.mli | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/utils.mli b/lib/utils.mli
> index 5687bf75867e..cf88a467fd54 100644
> --- a/lib/utils.mli
> +++ b/lib/utils.mli
> @@ -62,7 +62,7 @@ val backend_is_libvirt : unit -> bool
>  (** Return true iff the current backend is libvirt. *)
>  
>  val chown_for_libvirt_rhbz_1045069 : string -> unit
> -(** If running and root, and if the backend is libvirt, libvirt
> +(** If running as root, and if the backend is libvirt, libvirt
>      will run qemu as a non-root user.  This prevents access
>      to root-owned files and directories.  To fix this, provide
>      a function to chown things we might need to qemu:root so

Reviewed-by: Richard W.M. Jones <rjones at redhat.com>


-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.
http://libguestfs.org/virt-v2v


More information about the Libguestfs mailing list