[Libguestfs] [COMMON PATCH v3 1/4] inject_virtio_win: match only vendor/device/revision

[Laszlo Ersek]

On 3/10/23 18:54, Andrey Drobyshev wrote:
> From: Roman Kagan <rkagan at virtuozzo.com>
> 
> Since different hypervisor vendors are allowed to use their own vendor-id
> as PCI subsystem-vendor-id for virtio devices, during v2v conversion it
> makes sense to only match the vendor/device/revision and not the full device
> "path" in the Windows registry.  This way the code will remain universal but
> will work for different hypervisor vendors.
> 
> Signed-off-by: Andrey Drobyshev <andrey.drobyshev at virtuozzo.com>
> Originally-by: Roman Kagan <rkagan at virtuozzo.com>
> Acked-by: Laszlo Ersek <lersek at redhat.com>
> ---
>  mlcustomize/inject_virtio_win.ml | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/mlcustomize/inject_virtio_win.ml b/mlcustomize/inject_virtio_win.ml
> index 4e977b3..ed63fa7 100644
> --- a/mlcustomize/inject_virtio_win.ml
> +++ b/mlcustomize/inject_virtio_win.ml
> @@ -110,10 +110,10 @@ and get_inspection g root =
>      virtio_win = ""; was_set = false }
>  
>  let scsi_class_guid = "{4D36E97B-E325-11CE-BFC1-08002BE10318}"
> -let viostor_legacy_pciid = "VEN_1AF4&DEV_1001&SUBSYS_00021AF4&REV_00"
> -let viostor_modern_pciid = "VEN_1AF4&DEV_1042&SUBSYS_11001AF4&REV_01"
> -let vioscsi_legacy_pciid = "VEN_1AF4&DEV_1004&SUBSYS_00081AF4&REV_00"
> -let vioscsi_modern_pciid = "VEN_1AF4&DEV_1048&SUBSYS_11001AF4&REV_01"
> +let viostor_legacy_pciid = "VEN_1AF4&DEV_1001&REV_00"
> +let viostor_modern_pciid = "VEN_1AF4&DEV_1042&REV_01"
> +let vioscsi_legacy_pciid = "VEN_1AF4&DEV_1004&REV_00"
> +let vioscsi_modern_pciid = "VEN_1AF4&DEV_1048&REV_01"
>  
>  let rec inject_virtio_win_drivers ({ g } as t) reg =
>    (* Copy the virtio drivers to the guest. *)

Acked-by: Laszlo Ersek <lersek at redhat.com>