[Libguestfs] [libnbd PATCH 2/2] info: Show human sizes for block_size values

Eric Blake eblake at redhat.com
Wed Oct 18 13:22:10 UTC 2023


On Sun, Oct 08, 2023 at 11:34:05AM +0200, Laszlo Ersek wrote:
> On 10/7/23 11:27, Richard W.M. Jones wrote:
> > On Fri, Oct 06, 2023 at 10:18:09AM -0500, Eric Blake wrote:
> >> Adding a human-readable size for block constraints is useful.  For:
> >>
> >> $ ./run nbdinfo -- [ nbdkit memory \
> >>    --filter=blocksize-policy blocksize-preferred=32k 1M ] | grep pref
> >>
> >> this changes pre-patch:
> >> 	block_size_preferred: 32768
> >> to post-patch:
> >> 	block_size_preferred: 32768 (32K)
> > 
> > I think info/nbdinfo.pod needs to be updated.
> 
> Good catch!
> 
> With that:
> 
> series
> Reviewed-by: Laszlo Ersek <lersek at redhat.com>

Fixed, and series pushed as 42a85181..d4e8bb2d

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization:  qemu.org | libguestfs.org


More information about the Libguestfs mailing list