[Libguestfs] [libnbd PATCH] info: Prefer NBD_OPT_INFO when possible
Richard W.M. Jones
rjones at redhat.com
Tue Sep 5 14:25:47 UTC 2023
On Tue, Sep 05, 2023 at 08:47:34AM -0500, Eric Blake wrote:
> --- a/info/info-list-uris.sh
> +++ b/info/info-list-uris.sh
> @@ -22,7 +22,14 @@ set -e
> set -x
>
> requires nbdkit --version
> -requires nbdkit file --version
> +# Avoid tickling a double-free bug in nbdkit 1.35.11
> +requires nbdkit -U- -r file dir=. --run 'nbdsh --opt-mode -u "$uri" -c "
> +try:
> + h.opt_info()
> +except nbd.Error:
> + pass
> +h.opt_abort()
> +"'
Actually I think a problem with this is that it always causes a
segfault, which could leave a core dump around (does on my machine).
It's unfortunate, because obviously you can't test for a double-free
in nbdkit without causing a double-free.
It might be a rare case when a version test is better.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines. Supports shell scripting,
bindings from many languages. http://libguestfs.org
More information about the Libguestfs
mailing list