<div dir="ltr">In this case, shouldn't that be done by the upload-disk API ? When you upload a VM, oVirt knows what to do with it and handle the locking and any operations required to make the VM an oVirt VM.</div><div class="gmail_extra"><br><div class="gmail_quote">On 27 February 2018 at 13:53, Tomáš Golembiovský <span dir="ltr"><<a href="mailto:tgolembi@redhat.com" target="_blank">tgolembi@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Tue, 27 Feb 2018 13:43:59 +0100<br> Fabien Dupont <<a href="mailto:fdupont@redhat.com">fdupont@redhat.com</a>> wrote:<br> <br> > We can still find them and run the sysprep, but I have<br> > the feeling that it would be more logical if virt-v2v did the sysprep when<br> > target is oVirt / RHV.<br> <br> </span>This is trickier than you think. For LVM volumes somebody (VDSM) has to<br> lock and prepare the disks for you first and there is no external API to<br> do that AFAIK.<br> <br> Tomas<br> <div><div class="h5"><br> <br> ><br> > On 27 February 2018 at 13:34, Richard W.M. Jones <<a href="mailto:rjones@redhat.com">rjones@redhat.com</a>> wrote:<br> ><br> > > On Tue, Feb 27, 2018 at 12:53:08PM +0100, Pino Toscano wrote:<br> > > > On Tuesday, 27 February 2018 12:35:36 CET Tomáš Golembiovský wrote:<br> > > > > Remove ties to MAC address because it is likely to change.<br> > > ><br> > > > v2v tries to preserve the MAC address of network interfaces; few months<br> > > > ago we did a fix regarding this:<br> > > > <a href="https://bugzilla.redhat.com/show_bug.cgi?id=1506572" rel="noreferrer" target="_blank">https://bugzilla.redhat.com/<wbr>show_bug.cgi?id=1506572</a><br> > > ><br> > > > The approach of this patch is IMHO not good, since it removes the MAC<br> > > > address from the network-scripts, but still the rest of v2v will try<br> > > > to preserve the MAC addresses.<br> > ><br> > > We preserve the MAC address in metadata. On the other hand AIUI this<br> > > patch only removes the association in the ifcfg files and the guest<br> > > will reassociate it when it boots (albeit it might then mix up the<br> > > ethernet interfaces so that's not good).<br> > ><br> > > There's IMHO a bigger problem which is not being addressed:<br> > ><br> > > <a href="https://bugzilla.redhat.com/show_bug.cgi?id=1318922" rel="noreferrer" target="_blank">https://bugzilla.redhat.com/<wbr>show_bug.cgi?id=1318922</a><br> > ><br> > > > What's the reason behind this patch?<br> > ><br> > > There's a bit of background which is missing. Tomáš and I had some<br> > > discussions (privately, unfortunately) with the ManageIQ developers<br> > > who are integrating virt-v2v into MIQ/CloudForms. Their existing<br> > > software runs a separate virt-sysprep step on guests after they have<br> > > been converted by virt-v2v. They disable all sysprep the operations<br> > > except for just a couple, including ‘net-hwaddr’, so the effect is<br> > > roughly the same as this patch.<br> > ><br> > > The question was raised why they need to do that as a separate step<br> > > and why virt-v2v doesn't do it. And indeed there was some discussion<br> > > about whether or not converted guests need a new MAC address -- it's<br> > > at best unclear -- it is thought that VMware might reuse MAC addresses<br> > > which have "left" the hypervisor, although no one knows if that's<br> > > really true or not.<br> > ><br> > > I don't have much opinion on this. Maybe it's best for CFME to<br> > > continue to run virt-sysprep as a separate step.<br> > ><br> > > Rich.<br> > ><br> > > --<br> > > Richard Jones, Virtualization Group, Red Hat <a href="http://people.redhat.com/~" rel="noreferrer" target="_blank">http://people.redhat.com/~</a><br> > > rjones<br> > > Read my programming and virtualization blog: <a href="http://rwmj.wordpress.com" rel="noreferrer" target="_blank">http://rwmj.wordpress.com</a><br> > > libguestfs lets you edit virtual machines. Supports shell scripting,<br> > > bindings from many languages. <a href="http://libguestfs.org" rel="noreferrer" target="_blank">http://libguestfs.org</a><br> > ><br> ><br> ><br> ><br> > --<br> ><br> </div></div>> *Fabien Dupont*<br> <span class="">><br> > PRINCIPAL SOFTWARE ENGINEER<br> ><br> > Red Hat - Solutions Engineering<br> ><br> </span>> <a href="mailto:fabien@redhat.com">fabien@redhat.com</a> M: <a href="tel:%2B33%20%280%29%20662%20784%20971" value="+33662784971">+33 (0) 662 784 971</a> <<a href="tel:%2B33662784971" value="+33662784971">+33662784971</a>><br> ><br> > <<a href="http://redhat.com" rel="noreferrer" target="_blank">http://redhat.com</a>> *TRIED. TESTED. TRUSTED.*<br> ><br> > Twitter: @redhatway <<a href="https://twitter.com/redhatway" rel="noreferrer" target="_blank">https://twitter.com/redhatway</a><wbr>> | Instagram: @redhatinc<br> > <<a href="https://www.instagram.com/redhatinc/" rel="noreferrer" target="_blank">https://www.instagram.com/<wbr>redhatinc/</a>> | Snapchat: @redhatsnaps<br> <span class="HOEnZb"><font color="#888888"><br> <br> --<br> Tomáš Golembiovský <<a href="mailto:tgolembi@redhat.com">tgolembi@redhat.com</a>><br> </font></span></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><p style="margin:0px!important;padding:0px!important"><b style="font-family:arial,helvetica,sans-serif;font-size:small"><font color="#cc0000"><span style="margin:0px!important;padding:0px!important">Fabien</span> <span style="margin:0px!important;padding:0px!important">Dupont</span></font></b><br></p><p style="color:rgb(0,0,0);margin:0px!important;padding:0px!important"></p><p style="font-size:small;color:rgb(0,0,0);margin:0px!important;padding:0px!important"><span style="font-family:arial,helvetica,sans-serif;font-size:x-small">PRINCIPAL SOFTWARE ENGINEER</span><font size="1" face="arial, helvetica, sans-serif"><br style="margin:0px!important;padding:0px!important"></font></p><p style="font-size:small;margin:0px!important;padding:0px!important"><font face="arial, helvetica, sans-serif" size="1" color="#000000">Red Hat - Solutions Engineering</font></p><p style="margin:0px!important;padding:0px!important"><font size="1" face="arial, helvetica, sans-serif"><span style="margin:0px!important;padding:0px!important"><span style="margin:0px!important;padding:0px!important"><a href="mailto:fabien@redhat.com" target="_blank"><font color="#0b5394">fabien@redhat.com</font></a></span><font color="#000000"> </font></span><span style="margin:0px!important;padding:0px!important"><font color="#000000">M: </font><a href="tel:+33662784971" style="margin:0px!important;padding:0px!important" target="_blank"><font color="#0b5394">+33 (0) 662 784 971</font></a></span></font></p><p style="margin:0px!important;padding:0px!important"><span style="margin:0px!important;padding:0px!important"><font size="1" face="arial, helvetica, sans-serif"><a href="http://redhat.com" style="color:rgb(0,0,0)" target="_blank"><img src="https://www.redhat.com/profiles/rh/themes/redhatdotcom/img/logo-red-hat-black.png" width="96" height="30"></a><font color="#000000"> </font><span style="margin:0px!important;padding:0px!important"><font color="#cc0000"><b>TRIED. TESTED. TRUSTED.</b></font></span></font></span></p><p style="color:rgb(0,0,0);margin:0px!important;padding:0px!important"><font size="1" face="arial, helvetica, sans-serif"><span style="margin:0px!important;padding:0px!important"></span></font></p><div style="color:rgb(0,0,0);margin:0px!important;padding:0px!important"><div style="margin:0px!important;padding:0px!important"><font size="1" face="arial, helvetica, sans-serif">Twitter: <a href="https://twitter.com/redhatway" target="_blank">@redhatway</a> | Instagram: <a href="https://www.instagram.com/redhatinc/" target="_blank">@redhatinc</a> | Snapchat: @redhatsnaps</font></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div> </div>