<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On 27 Feb 2018, at 13:58, Fabien Dupont <<a href="mailto:fdupont@redhat.com" class="">fdupont@redhat.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">In this case, shouldn't that be done by the upload-disk API ? When you upload a VM, oVirt knows what to do with it and handle the locking and any operations required to make the VM an oVirt VM.</div></div></blockquote><div><br class=""></div>upload API is uploading individual disks, for the duration of the upload they are locked</div><div>there is no public API to explicitly lock/unlock them</div><div>“uploading VM” is a different API concerning only the VM definition (using the virt-v2v’s resulting OVF, internally connecting the pre-uploaded disks to taht VM)</div><div><br class=""></div><div>it’s would probably good enough to go without locking for starts, but it’s just better to avoid that completely and have an option for MAC cleanup during virt-v2v. And leave other post conversion changes to a separate script (further editing the VM using public API)</div><div><br class=""></div><div><blockquote type="cite" class=""><div class=""><div class="gmail_extra"><br class=""><div class="gmail_quote">On 27 February 2018 at 13:53, Tomáš Golembiovský <span dir="ltr" class=""><<a href="mailto:tgolembi@redhat.com" target="_blank" class="">tgolembi@redhat.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Tue, 27 Feb 2018 13:43:59 +0100<br class="">
Fabien Dupont <<a href="mailto:fdupont@redhat.com" class="">fdupont@redhat.com</a>> wrote:<br class="">
<br class="">
> We can still find them and run the sysprep, but I have<br class="">
> the feeling that it would be more logical if virt-v2v did the sysprep when<br class="">
> target is oVirt / RHV.<br class="">
<br class="">
</span>This is trickier than you think. For LVM volumes somebody (VDSM) has to<br class="">
lock and prepare the disks for you first and there is no external API to<br class="">
do that AFAIK.<br class="">
<br class="">
Tomas<br class="">
<div class=""><div class="h5"><br class="">
<br class="">
><br class="">
> On 27 February 2018 at 13:34, Richard W.M. Jones <<a href="mailto:rjones@redhat.com" class="">rjones@redhat.com</a>> wrote:<br class="">
><br class="">
> > On Tue, Feb 27, 2018 at 12:53:08PM +0100, Pino Toscano wrote:<br class="">
> > > On Tuesday, 27 February 2018 12:35:36 CET Tomáš Golembiovský wrote:<br class="">
> > > > Remove ties to MAC address because it is likely to change.<br class="">
> > ><br class="">
> > > v2v tries to preserve the MAC address of network interfaces; few months<br class="">
> > > ago we did a fix regarding this:<br class="">
> > > <a href="https://bugzilla.redhat.com/show_bug.cgi?id=1506572" rel="noreferrer" target="_blank" class="">https://bugzilla.redhat.com/<wbr class="">show_bug.cgi?id=1506572</a><br class="">
> > ><br class="">
> > > The approach of this patch is IMHO not good, since it removes the MAC<br class="">
> > > address from the network-scripts, but still the rest of v2v will try<br class="">
> > > to preserve the MAC addresses.<br class="">
> ><br class="">
> > We preserve the MAC address in metadata. On the other hand AIUI this<br class="">
> > patch only removes the association in the ifcfg files and the guest<br class="">
> > will reassociate it when it boots (albeit it might then mix up the<br class="">
> > ethernet interfaces so that's not good).<br class="">
> ><br class="">
> > There's IMHO a bigger problem which is not being addressed:<br class="">
> ><br class="">
> > <a href="https://bugzilla.redhat.com/show_bug.cgi?id=1318922" rel="noreferrer" target="_blank" class="">https://bugzilla.redhat.com/<wbr class="">show_bug.cgi?id=1318922</a><br class="">
> ><br class="">
> > > What's the reason behind this patch?<br class="">
> ><br class="">
> > There's a bit of background which is missing. Tomáš and I had some<br class="">
> > discussions (privately, unfortunately) with the ManageIQ developers<br class="">
> > who are integrating virt-v2v into MIQ/CloudForms. Their existing<br class="">
> > software runs a separate virt-sysprep step on guests after they have<br class="">
> > been converted by virt-v2v. They disable all sysprep the operations<br class="">
> > except for just a couple, including ‘net-hwaddr’, so the effect is<br class="">
> > roughly the same as this patch.<br class="">
> ><br class="">
> > The question was raised why they need to do that as a separate step<br class="">
> > and why virt-v2v doesn't do it. And indeed there was some discussion<br class="">
> > about whether or not converted guests need a new MAC address -- it's<br class="">
> > at best unclear -- it is thought that VMware might reuse MAC addresses<br class="">
> > which have "left" the hypervisor, although no one knows if that's<br class="">
> > really true or not.<br class="">
> ><br class="">
> > I don't have much opinion on this. Maybe it's best for CFME to<br class="">
> > continue to run virt-sysprep as a separate step.<br class="">
> ><br class="">
> > Rich.<br class="">
> ><br class="">
> > --<br class="">
> > Richard Jones, Virtualization Group, Red Hat <a href="http://people.redhat.com/~" rel="noreferrer" target="_blank" class="">http://people.redhat.com/~</a><br class="">
> > rjones<br class="">
> > Read my programming and virtualization blog: <a href="http://rwmj.wordpress.com/" rel="noreferrer" target="_blank" class="">http://rwmj.wordpress.com</a><br class="">
> > libguestfs lets you edit virtual machines. Supports shell scripting,<br class="">
> > bindings from many languages. <a href="http://libguestfs.org/" rel="noreferrer" target="_blank" class="">http://libguestfs.org</a><br class="">
> ><br class="">
><br class="">
><br class="">
><br class="">
> --<br class="">
><br class="">
</div></div>> *Fabien Dupont*<br class="">
<span class="">><br class="">
> PRINCIPAL SOFTWARE ENGINEER<br class="">
><br class="">
> Red Hat - Solutions Engineering<br class="">
><br class="">
</span>> <a href="mailto:fabien@redhat.com" class="">fabien@redhat.com</a> M: <a href="tel:%2B33%20%280%29%20662%20784%20971" value="+33662784971" class="">+33 (0) 662 784 971</a> <<a href="tel:%2B33662784971" value="+33662784971" class="">+33662784971</a>><br class="">
><br class="">
> <<a href="http://redhat.com/" rel="noreferrer" target="_blank" class="">http://redhat.com</a>> *TRIED. TESTED. TRUSTED.*<br class="">
><br class="">
> Twitter: @redhatway <<a href="https://twitter.com/redhatway" rel="noreferrer" target="_blank" class="">https://twitter.com/redhatway</a><wbr class="">> | Instagram: @redhatinc<br class="">
> <<a href="https://www.instagram.com/redhatinc/" rel="noreferrer" target="_blank" class="">https://www.instagram.com/<wbr class="">redhatinc/</a>> | Snapchat: @redhatsnaps<br class="">
<span class="HOEnZb"><font color="#888888" class=""><br class="">
<br class="">
--<br class="">
Tomáš Golembiovský <<a href="mailto:tgolembi@redhat.com" class="">tgolembi@redhat.com</a>><br class="">
</font></span></blockquote></div><br class=""><br clear="all" class=""><div class=""><br class=""></div>-- <br class=""><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr" class=""><div class=""><div dir="ltr" class=""><div dir="ltr" class=""><div dir="ltr" class=""><div dir="ltr" class=""><div dir="ltr" class=""><div dir="ltr" class=""><div dir="ltr" class=""><div dir="ltr" class=""><div dir="ltr" class=""><div dir="ltr" class=""><div dir="ltr" class=""><div style="margin: 0px !important; padding: 0px !important;" class=""><b style="font-family:arial,helvetica,sans-serif;font-size:small" class=""><font color="#cc0000" class=""><span style="margin:0px!important;padding:0px!important" class="">Fabien</span> <span style="margin:0px!important;padding:0px!important" class="">Dupont</span></font></b><br class=""></div><p style="margin: 0px !important; padding: 0px !important;" class=""></p><div style="font-size: small; margin: 0px !important; padding: 0px !important;" class=""><span style="font-family:arial,helvetica,sans-serif;font-size:x-small" class="">PRINCIPAL SOFTWARE ENGINEER</span><font size="1" face="arial, helvetica, sans-serif" class=""><br style="margin:0px!important;padding:0px!important" class=""></font></div><div style="font-size: small; margin: 0px !important; padding: 0px !important;" class=""><font face="arial, helvetica, sans-serif" size="1" class="">Red Hat - Solutions Engineering</font></div><div style="margin: 0px !important; padding: 0px !important;" class=""><font size="1" face="arial, helvetica, sans-serif" class=""><span style="margin:0px!important;padding:0px!important" class=""><span style="margin:0px!important;padding:0px!important" class=""><a href="mailto:fabien@redhat.com" target="_blank" class=""><font color="#0b5394" class="">fabien@redhat.com</font></a></span><font class=""> </font></span><span style="margin:0px!important;padding:0px!important" class=""><font class="">M: </font><a href="tel:+33662784971" style="margin:0px!important;padding:0px!important" target="_blank" class=""><font color="#0b5394" class="">+33 (0) 662 784 971</font></a></span></font></div><div style="margin: 0px !important; padding: 0px !important;" class=""><span style="margin:0px!important;padding:0px!important" class=""><font size="1" face="arial, helvetica, sans-serif" class=""><a href="http://redhat.com/" style="" target="_blank" class=""><img src="https://www.redhat.com/profiles/rh/themes/redhatdotcom/img/logo-red-hat-black.png" width="96" height="30" class=""></a><font class=""> </font><span style="margin:0px!important;padding:0px!important" class=""><font color="#cc0000" class=""><b class="">TRIED. TESTED. TRUSTED.</b></font></span></font></span></div><p style="margin: 0px !important; padding: 0px !important;" class=""><font size="1" face="arial, helvetica, sans-serif" class=""><span style="margin:0px!important;padding:0px!important" class=""></span></font></p><div style="margin: 0px !important; padding: 0px !important;" class=""><div style="margin:0px!important;padding:0px!important" class=""><font size="1" face="arial, helvetica, sans-serif" class="">Twitter: <a href="https://twitter.com/redhatway" target="_blank" class="">@redhatway</a> | Instagram: <a href="https://www.instagram.com/redhatinc/" target="_blank" class="">@redhatinc</a> | Snapchat: @redhatsnaps</font></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div>
</div>
</div></blockquote></div><br class=""></body></html>