<div dir="ltr"><div class="gmail_quote"><div dir="ltr">On Tue, Jun 5, 2018 at 9:19 PM Richard W.M. Jones <<a href="mailto:rjones@redhat.com">rjones@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This increases the inactivity timeout for transfers from the default<br>
(60 seconds) to 1 hour, so that we should never hit it for ordinary<br>
transfers.<br>
<br>
Note this requires oVirt >= 4.3.0 although the same change was<br>
backported to the 4.2 branch in later releases. The corresponding<br>
oVirt fix was in <a href="https://bugzilla.redhat.com/1563278" rel="noreferrer" target="_blank">https://bugzilla.redhat.com/1563278</a></blockquote><div><br></div><div>I don't think this requires 4.3. RHV QE verified on 4.2.3.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I also replaced the deprecated ‘image’ parameter with ‘disk’.<br></blockquote><div><br></div><div>I assume that you don't care about backward compatibility,</div><div>and users will have to run latest version of oVirt/RHV to</div><div>use this?</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Thanks: Nir Soffer, Daniel Erez.<br>
---<br>
v2v/rhv-upload-plugin.py | 5 ++---<br>
1 file changed, 2 insertions(+), 3 deletions(-)<br>
<br>
diff --git a/v2v/rhv-upload-plugin.py b/v2v/rhv-upload-plugin.py<br>
index c3de7d555..44972de21 100644<br>
--- a/v2v/rhv-upload-plugin.py<br>
+++ b/v2v/rhv-upload-plugin.py<br>
@@ -123,9 +123,8 @@ def open(readonly):<br>
# Create a new image transfer.<br>
transfer = transfers_service.add(<br>
types.ImageTransfer(<br>
- image = types.Image(<br>
- id = <a href="http://disk.id" rel="noreferrer" target="_blank">disk.id</a><br>
- )<br>
+ disk = types.Disk(id = <a href="http://disk.id" rel="noreferrer" target="_blank">disk.id</a>),<br>
+ inactivity_timeout = 0,<br></blockquote><div><br></div><div>Using 0 disables the timeout mechanism, did you mean 3600?</div><div> <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
)<br>
)<br>
debug("<a href="http://transfer.id" rel="noreferrer" target="_blank">transfer.id</a> = %r" % <a href="http://transfer.id" rel="noreferrer" target="_blank">transfer.id</a>)<br>
-- <br>
2.16.2<br>
<br>
</blockquote></div></div>