<div dir="auto">Gentle ping</div> <div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Jun 30, 2020, 14:25 Sam Eiderman <<a href="mailto:sameid@google.com">sameid@google.com</a>> wrote: </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Yea, I noticed that commit, but since it was used in gpt too regardless of that commit, I decided not to mention this regression. I also noticed that list_filesystems() still works, this is probably due to filtering of devices (daemon/<a href="http://listfs.ml" rel="noreferrer noreferrer" target="_blank">listfs.ml</a>): "let devices = List.filter is_not_partitioned_device devices in" What do you have in mind here? On Tue, Jun 30, 2020 at 12:33 PM Pino Toscano <<a href="mailto:ptoscano@redhat.com" target="_blank" rel="noreferrer">ptoscano@redhat.com</a>> wrote: > > On Tuesday, 30 June 2020 10:33:40 CEST Sam Eiderman wrote: > > By creating an empty disk and using it as the first disk of the vm (i.e. > > /dev/sda, /dev/sdb{1,2} contains the windows fses) we change the > > iteration order of the disks. > > This causes inspect_os() to fail since Parted returns a Unix_error if > > the device does not contain any partitions - fix this by handling this > > Unix_error. > > > > Signed-off-by: Sam Eiderman <<a href="mailto:sameid@google.com" target="_blank" rel="noreferrer">sameid@google.com</a>> > > --- > > daemon/<a href="http://inspect_fs_windows.ml" rel="noreferrer noreferrer" target="_blank">inspect_fs_windows.ml</a> | 11 ++++++++--- > > 1 file changed, 8 insertions(+), 3 deletions(-) > > > > diff --git a/daemon/<a href="http://inspect_fs_windows.ml" rel="noreferrer noreferrer" target="_blank">inspect_fs_windows.ml</a> b/daemon/<a href="http://inspect_fs_windows.ml" rel="noreferrer noreferrer" target="_blank">inspect_fs_windows.ml</a> > > index c4a05bc38..bc6b98b60 100644 > > --- a/daemon/<a href="http://inspect_fs_windows.ml" rel="noreferrer noreferrer" target="_blank">inspect_fs_windows.ml</a> > > +++ b/daemon/<a href="http://inspect_fs_windows.ml" rel="noreferrer noreferrer" target="_blank">inspect_fs_windows.ml</a> > > @@ -365,8 +365,10 @@ and map_registry_disk_blob_mbr devices blob = > > let device = > > List.find ( > > fun dev -> > > - Parted.part_get_parttype dev = "msdos" && > > - pread dev 4 0x01b8 = diskid > > + try > > + Parted.part_get_parttype dev = "msdos" && > > + pread dev 4 0x01b8 = diskid > > + with Unix.Unix_error (Unix.EINVAL, _, _) -> false > > The old C inspection code did not check for the partition type: > <a href="https://github.com/libguestfs/libguestfs/blob/stable-1.36/lib/inspect-fs-windows.c#L591" rel="noreferrer noreferrer" target="_blank">https://github.com/libguestfs/libguestfs/blob/stable-1.36/lib/inspect-fs-windows.c#L591</a> > The partition type check was added recently: > <a href="https://github.com/libguestfs/libguestfs/commit/7b4d13626ff878b124d01ec452a4fd0052934133" rel="noreferrer noreferrer" target="_blank">https://github.com/libguestfs/libguestfs/commit/7b4d13626ff878b124d01ec452a4fd0052934133</a> > > TBH I'd rather prefer that we check for the situation explicitly > before, rather than catching a generic EINVAL error. Or, even better, > try to avoid altogether the situation that 7b4d13626ff878 checks, > handling this issue as well. > > > @@ -402,7 +404,10 @@ and map_registry_disk_blob_gpt partitions blob = > > fun part -> > > let partnum = Devsparts.part_to_partnum part in > > let device = Devsparts.part_to_dev part in > > - let typ = Parted.part_get_parttype device in > > + let typ = > > + try > > + Parted.part_get_parttype device > > + with Unix.Unix_error (Unix.EINVAL, _, _) -> "unknown" in > > if typ <> "gpt" then false > > else ( > > Ditto. > > -- > Pino Toscano_______________________________________________ > Libguestfs mailing list > <a href="mailto:Libguestfs@redhat.com" target="_blank" rel="noreferrer">Libguestfs@redhat.com</a> > <a href="https://www.redhat.com/mailman/listinfo/libguestfs" rel="noreferrer noreferrer" target="_blank">https://www.redhat.com/mailman/listinfo/libguestfs</a> </blockquote></div>