<div dir="ltr"><div dir="ltr">On Mon, Jan 25, 2021 at 1:49 PM Richard W.M. Jones <<a href="mailto:rjones@redhat.com">rjones@redhat.com</a>> wrote:<br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Mon, Jan 25, 2021 at 01:44:26PM +0200, Nir Soffer wrote:<br>
> On Mon, Jan 25, 2021 at 11:58 AM Richard W.M. Jones <<a href="mailto:rjones@redhat.com" target="_blank">rjones@redhat.com</a>> wrote:<br>
> ><br>
> ><br>
> > This series is fine apart from two typos. You can push it<br>
> > if you want, unless you want to do more testing/tweaking.<br>
> <br>
> I want to test it first with a real environment since my tests are<br>
> not stable.<br>
> <br>
> Also I'm worried about using -W for all conversion - we should use it only<br>
> if the output is using parallel thread model, otherwise it does not give<br>
> any benefit and it will may cause unwanted fragmentation in the target<br>
> image.<br>
> <br>
> Should we have something like:<br>
> <br>
> if output#parallel then<br>
> use unordered writes...<br>
> <br>
> What do you think?<br>
<br>
Yes, good idea. Although maybe output#write_out_of_order is better as<br>
that is how the qemu-img -W option is described in the docs.<br></blockquote><div><br></div><div>Yes, that's more clear</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
Rich.<br>
<br>
-- <br>
Richard Jones, Virtualization Group, Red Hat <a href="http://people.redhat.com/~rjones" rel="noreferrer" target="_blank">http://people.redhat.com/~rjones</a><br>
Read my programming and virtualization blog: <a href="http://rwmj.wordpress.com" rel="noreferrer" target="_blank">http://rwmj.wordpress.com</a><br>
virt-builder quickly builds VMs from scratch<br>
<a href="http://libguestfs.org/virt-builder.1.html" rel="noreferrer" target="_blank">http://libguestfs.org/virt-builder.1.html</a><br>
<br>
</blockquote></div></div>