<div dir="auto">Hello<div dir="auto"><br></div><div dir="auto">This commit caused a regression with LDM devices: <a href="https://github.com/libguestfs/libguestfs/commit/86577ee3883836c1c4fff258c05261bd3858e22b" rel="noreferrer noreferrer noreferrer noreferrer" target="_blank">https://github.com/libguestfs/libguestfs/commit/86577ee3883836c1c4fff258c05261bd3858e22b</a></div><div dir="auto"><br></div><div dir="auto">1. list-filesystems double all LDM volumes:</div><div dir="auto"><br></div><div dir="auto"><span style="font-family:calibri,arial,helvetica,sans-serif;font-size:16px">><fs> list-filesystems</span><div style="font-family:calibri,arial,helvetica,sans-serif;font-size:16px" dir="auto">/dev/mapper/ldm_vol_AQ-W10-EFI-VM-Dg0_Volume5: ntfs</div><div style="font-family:calibri,arial,helvetica,sans-serif;font-size:16px" dir="auto">/dev/sda1: ntfs</div><div style="font-family:calibri,arial,helvetica,sans-serif;font-size:16px" dir="auto">/dev/sda2: vfat</div><div style="font-family:calibri,arial,helvetica,sans-serif;font-size:16px" dir="auto">/dev/mapper/ldm_vol_AQ-W10-EFI-VM-Dg0_Volume5: ntfs</div><div dir="auto"><br></div>2. inspect-os in this case detects 2 OSes:</div><div dir="auto"><br></div><div dir="auto"><div style="font-family:calibri,arial,helvetica,sans-serif;font-size:16px" dir="auto">><fs> inspect-os</div><div style="font-family:calibri,arial,helvetica,sans-serif;font-size:16px" dir="auto">/dev/mapper/ldm_vol_AQ-W10-EFI-VM-Dg0_Volume5</div><div style="font-family:calibri,arial,helvetica,sans-serif;font-size:16px" dir="auto">/dev/mapper/ldm_vol_AQ-W10-EFI-VM-Dg0_Volume5</div><div style="font-family:calibri,arial,helvetica,sans-serif;font-size:16px" dir="auto"><br></div><div style="font-family:calibri,arial,helvetica,sans-serif;font-size:16px" dir="auto">The issue is that now we explicitly adds DM devices to a list of file systems, but latter we also selectively adds LDM volumes. Which also DM devices:</div><div style="font-family:calibri,arial,helvetica,sans-serif;font-size:16px" dir="auto"><br></div><div style="font-family:calibri,arial,helvetica,sans-serif;font-size:16px" dir="auto"><div dir="auto">><fs> list-ldm-volumes</div><div dir="auto">/dev/mapper/ldm_vol_AQ-W10-EFI-VM-Dg0_Volume5</div><div dir="auto"><br></div><div dir="auto">><fs> list-dm-devices</div>/dev/mapper/ldm_vol_AQ-W10-EFI-VM-Dg0_Volume5<br></div><div style="font-family:calibri,arial,helvetica,sans-serif;font-size:16px" dir="auto"><br></div><div style="font-family:calibri,arial,helvetica,sans-serif;font-size:16px" dir="auto">It would be easy to fix leaving only unique file systems eliminating duplicates, however it would not help if LDM contains volumes of type other than simple. Such a volumes consist of LDM partitions which are also DM devices and thus the mentioned patch will include them into a list if file systems but LDM partitions cannot contains file system. Here you can see an example of both cases where list-filesystems returns doubled LDM volumes as well as LDM partitions. Later cannot contains file system:</div><div style="font-family:calibri,arial,helvetica,sans-serif;font-size:16px" dir="auto"><br></div><div style="font-family:calibri,arial,helvetica,sans-serif;font-size:16px" dir="auto">><fs> list-filesystems<div dir="auto">/dev/mapper/ldm_part_WIN-RSVUTBNGR5D-Dg0_Disk1-01: unknown</div><div dir="auto">/dev/mapper/ldm_part_WIN-RSVUTBNGR5D-Dg0_Disk1-02: ntfs</div><div dir="auto">/dev/mapper/ldm_part_WIN-RSVUTBNGR5D-Dg0_Disk2-01: unknown</div><div dir="auto">/dev/mapper/ldm_part_WIN-RSVUTBNGR5D-Dg0_Disk2-02: ntfs</div><div dir="auto">/dev/mapper/ldm_part_WIN-RSVUTBNGR5D-Dg0_Disk3-01: unknown</div><div dir="auto">/dev/mapper/ldm_vol_WIN-RSVUTBNGR5D-Dg0_Volume1: ntfs</div><div dir="auto">/dev/mapper/ldm_vol_WIN-RSVUTBNGR5D-Dg0_Volume10: ntfs</div><div dir="auto">/dev/mapper/ldm_vol_WIN-RSVUTBNGR5D-Dg0_Volume11: ntfs</div><div dir="auto">/dev/mapper/ldm_vol_WIN-RSVUTBNGR5D-Dg0_Volume2: ntfs</div><div dir="auto">/dev/mapper/ldm_vol_WIN-RSVUTBNGR5D-Dg0_Volume3: ntfs</div><div dir="auto">/dev/mapper/ldm_vol_WIN-RSVUTBNGR5D-Dg0_Volume4: ntfs</div><div dir="auto">/dev/mapper/ldm_vol_WIN-RSVUTBNGR5D-Dg0_Volume5: vfat</div><div dir="auto">/dev/mapper/ldm_vol_WIN-RSVUTBNGR5D-Dg0_Volume6: ntfs</div><div dir="auto">/dev/mapper/ldm_vol_WIN-RSVUTBNGR5D-Dg0_Volume7: vfat</div><div dir="auto">/dev/mapper/ldm_vol_WIN-RSVUTBNGR5D-Dg0_Volume8: ntfs</div><div dir="auto">/dev/mapper/ldm_vol_WIN-RSVUTBNGR5D-Dg0_Volume9: unknown</div><div dir="auto">/dev/mapper/ldm_vol_WIN-RSVUTBNGR5D-Dg0_Volume1: ntfs</div><div dir="auto">/dev/mapper/ldm_vol_WIN-RSVUTBNGR5D-Dg0_Volume10: ntfs</div><div dir="auto">/dev/mapper/ldm_vol_WIN-RSVUTBNGR5D-Dg0_Volume11: ntfs</div><div dir="auto">/dev/mapper/ldm_vol_WIN-RSVUTBNGR5D-Dg0_Volume2: ntfs</div><div dir="auto">/dev/mapper/ldm_vol_WIN-RSVUTBNGR5D-Dg0_Volume3: ntfs</div><div dir="auto">/dev/mapper/ldm_vol_WIN-RSVUTBNGR5D-Dg0_Volume4: ntfs</div><div dir="auto">/dev/mapper/ldm_vol_WIN-RSVUTBNGR5D-Dg0_Volume5: vfat</div><div dir="auto">/dev/mapper/ldm_vol_WIN-RSVUTBNGR5D-Dg0_Volume6: ntfs</div><div dir="auto">/dev/mapper/ldm_vol_WIN-RSVUTBNGR5D-Dg0_Volume7: vfat</div><div dir="auto">/dev/mapper/ldm_vol_WIN-RSVUTBNGR5D-Dg0_Volume8: ntfs</div>/dev/mapper/ldm_vol_WIN-RSVUTBNGR5D-Dg0_Volume9: unknown<br></div><div style="font-family:calibri,arial,helvetica,sans-serif;font-size:16px" dir="auto"><br></div><div data-smartmail="gmail_signature" dir="auto">--<br>  Mykola Ivanets</div></div></div>