<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Mar 25, 2013 at 9:46 AM, Christophe Fergeau <span dir="ltr"><<a href="mailto:cfergeau@redhat.com" target="_blank">cfergeau@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hey,<br>
<br>
Can we not just drop it rather than making it conditional?<br>
<a href="http://fedoraproject.org/wiki/Anaconda/Kickstart#network" target="_blank">http://fedoraproject.org/wiki/Anaconda/Kickstart#network</a> says<br>
'Device of the first network command is activated if network is required,<br>
e.g. in case of network installation or using vnc. Activation of the device<br>
can be also explicitly required by --activate option.'<br>
<br>
so it would seem this will be done automatically if needed?<br></blockquote><div><br></div><div>Yes, after a few tests here I can say you are right.<br> </div><div>Should I resend the patch?<br></div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="HOEnZb"><div class="h5"><br>
On Sat, Mar 23, 2013 at 03:09:24PM +0100, Fabiano Fidêncio wrote:<br>
> ---<br>
> data/install-scripts/fedora.xml | 2 +-<br>
> data/install-scripts/rhel.xml | 2 +-<br>
> 2 files changed, 2 insertions(+), 2 deletions(-)<br>
><br>
> diff --git a/data/install-scripts/fedora.xml b/data/install-scripts/fedora.xml<br>
> index 6e8a92d..0d14b28 100644<br>
> --- a/data/install-scripts/fedora.xml<br>
> +++ b/data/install-scripts/fedora.xml<br>
> @@ -216,7 +216,7 @@ reboot<br>
> install<br>
> keyboard '<xsl:call-template name="keyboard"/>'<br>
> lang <xsl:value-of select="config/l10n-language"/><br>
> -network --onboot yes --device eth0 --bootproto dhcp --noipv6 --hostname=<xsl:value-of select="config/hostname"/> --activate<br>
> +network --onboot yes --device eth0 --bootproto dhcp --noipv6 --hostname=<xsl:value-of select="config/hostname"/> <xsl:if test="os/version > 16">--activate</xsl:if><br>
> rootpw dummyPa55w0rd # Actual password set (or unset) in %post below<br>
> firewall --disabled<br>
> authconfig --enableshadow --enablemd5<br>
> diff --git a/data/install-scripts/rhel.xml b/data/install-scripts/rhel.xml<br>
> index 9c17f11..5942826 100644<br>
> --- a/data/install-scripts/rhel.xml<br>
> +++ b/data/install-scripts/rhel.xml<br>
> @@ -124,7 +124,7 @@ reboot<br>
> install<br>
> keyboard us<br>
> lang <xsl:value-of select="config/l10n-language"/><br>
> -network --onboot yes --device eth0 --bootproto dhcp --noipv6 --hostname=<xsl:value-of select="config/hostname"/> --activate<br>
> +network --onboot yes --device eth0 --bootproto dhcp --noipv6 --hostname=<xsl:value-of select="config/hostname"/> <xsl:if test="os/version > 6.0">--activate</xsl:if><br>
> rootpw dummyPa55w0rd # Actual password set (or unset) in %post below<br>
> firewall --disabled<br>
> authconfig --enableshadow --enablemd5<br>
> --<br>
> 1.8.1.4<br>
><br>
> _______________________________________________<br>
> Libosinfo mailing list<br>
> <a href="mailto:Libosinfo@redhat.com">Libosinfo@redhat.com</a><br>
> <a href="https://www.redhat.com/mailman/listinfo/libosinfo" target="_blank">https://www.redhat.com/mailman/listinfo/libosinfo</a><br>
</div></div><br>_______________________________________________<br>
Libosinfo mailing list<br>
<a href="mailto:Libosinfo@redhat.com">Libosinfo@redhat.com</a><br>
<a href="https://www.redhat.com/mailman/listinfo/libosinfo" target="_blank">https://www.redhat.com/mailman/listinfo/libosinfo</a><br>
<br></blockquote></div><br><br clear="all"><br>-- <br><div>Fabiano Fidêncio</div>
</div></div>