<div dir="ltr"><div>Hello,</div><div>thank you for yours review. I am sending you new version.</div><div><br></div><div>BR</div><div>Vera<br></div></div><br><div class="gmail_quote"><div dir="ltr">On Tue, Oct 16, 2018 at 10:57 AM Daniel P. Berrangé <<a href="mailto:berrange@redhat.com">berrange@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Mon, Oct 15, 2018 at 07:43:59PM +0200, Věra Cholasta wrote:<br>
> ---<br>
>  tests/test-isodetect.c | 10 ++++------<br>
>  1 file changed, 4 insertions(+), 6 deletions(-)<br>
> <br>
> diff --git a/tests/test-isodetect.c b/tests/test-isodetect.c<br>
> index 76f0c5a..f40f5cc 100644<br>
> --- a/tests/test-isodetect.c<br>
> +++ b/tests/test-isodetect.c<br>
> @@ -390,17 +390,16 @@ static void test_one(const gchar *vendor)<br>
>  <br>
>      g_assert_nonnull(isos);<br>
>  <br>
> -    tmp = isos;<br>
> -    while (tmp) {<br>
> +    for (tmp = isos; tmp; tmp = tmp->next) {<br>
>          struct ISOInfo *info  = tmp->data;<br>
>          gboolean matched = osinfo_db_identify_media(db, info->media);<br>
>          OsinfoOs *os;<br>
>  <br>
>          g_test_message("checking OS %s for ISO %s",<br>
>                         info->shortid, info->filename);<br>
> +        g_assert_true(matched);<br>
>          if (!matched) {<br>
> -            g_error("ISO %s was not matched by OS %s",<br>
> -                    info->filename, info->shortid);<br>
> +            continue;<br>
<br>
You've removed the message that tells us what actually failed.<br>
<br>
<br>
Regards,<br>
Daniel<br>
-- <br>
|: <a href="https://berrange.com" rel="noreferrer" target="_blank">https://berrange.com</a>      -o-    <a href="https://www.flickr.com/photos/dberrange" rel="noreferrer" target="_blank">https://www.flickr.com/photos/dberrange</a> :|<br>
|: <a href="https://libvirt.org" rel="noreferrer" target="_blank">https://libvirt.org</a>         -o-            <a href="https://fstop138.berrange.com" rel="noreferrer" target="_blank">https://fstop138.berrange.com</a> :|<br>
|: <a href="https://entangle-photo.org" rel="noreferrer" target="_blank">https://entangle-photo.org</a>    -o-    <a href="https://www.instagram.com/dberrange" rel="noreferrer" target="_blank">https://www.instagram.com/dberrange</a> :|<br>
</blockquote></div>