<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Feb 14, 2019 at 6:28 PM Cole Robinson <<a href="mailto:crobinso@redhat.com">crobinso@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 12/21/18 9:09 AM, Fabiano Fidêncio wrote:<br>
> Signed-off-by: Fabiano Fidêncio <<a href="mailto:fidencio@redhat.com" target="_blank">fidencio@redhat.com</a>><br>
> ---<br>
>  data/os/<a href="http://centos.org/centos-7.0.xml.in" rel="noreferrer" target="_blank">centos.org/centos-7.0.xml.in</a> | 1 +<br>
>  1 file changed, 1 insertion(+)<br>
> <br>
> diff --git a/data/os/<a href="http://centos.org/centos-7.0.xml.in" rel="noreferrer" target="_blank">centos.org/centos-7.0.xml.in</a> b/data/os/<a href="http://centos.org/centos-7.0.xml.in" rel="noreferrer" target="_blank">centos.org/centos-7.0.xml.in</a><br>
> index 8b3531e..cc583b9 100644<br>
> --- a/data/os/<a href="http://centos.org/centos-7.0.xml.in" rel="noreferrer" target="_blank">centos.org/centos-7.0.xml.in</a><br>
> +++ b/data/os/<a href="http://centos.org/centos-7.0.xml.in" rel="noreferrer" target="_blank">centos.org/centos-7.0.xml.in</a><br>
> @@ -3,6 +3,7 @@<br>
>       See <a href="http://www.gnu.org/licenses/" rel="noreferrer" target="_blank">http://www.gnu.org/licenses/</a> for a copy of the license text --><br>
>    <os id="<a href="http://centos.org/centos/7.0" rel="noreferrer" target="_blank">http://centos.org/centos/7.0</a>"><br>
>      <short-id>centos7.0</short-id><br>
> +    <short-id>centos7</short-id><br>
>      <_name>CentOS 7.0</_name><br>
>      <version>7.0</version><br>
>      <_vendor>CentOS</_vendor><br>
> <br>
<br>
Huh I didn't know we could do that, but I see we do the same for debian<br>
distros, so it makes sense<br>
<br></blockquote><div><br></div><div>Cole, I will end up dropping this patch.</div><div>While we can do that (as in our schema allows that), there's no code on libosinfo that would properly deal with a second short-id.</div><div><br></div><div>So, for now, I'll not go for this patch.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
Reviewed-by: Cole Robinson <<a href="mailto:crobinso@redhat.com" target="_blank">crobinso@redhat.com</a>><br>
<br>
- Cole<br>
</blockquote></div></div>