[libvirt] [PATCH V3 0/8] virsh: rework command parsing

Eric Blake eblake at redhat.com
Tue Oct 12 16:26:50 UTC 2010


On 10/12/2010 09:50 AM, Eric Blake wrote:
> On 10/12/2010 01:13 AM, Lai Jiangshan wrote:
>>
>>
>> Old virsh command parsing mashes all the args back into a string and
>> miss the quotes, this patches fix it. It is also needed for introducing
>> qemu-monitor-command which is very useful.
>>
>> This patches add vrshCommandParser abstraction to parser the args.
>
> Thanks for splitting it up! It will make reviews easier. However, in the
> future, you should try and convince 'git send-email' or whatever
> mechanism you use to send patches to do shallow threading (all 8 of the
> n/8 patches should be in-reply-to the 0/8 cover letter), as it makes
> reviewing easier when the series is a single thread.

Now that I've done a bit more research; here's the results, to make it 
easier for others to do:

git config sendemail.chainreplyto false
git config sendemail.thread false
git config format.thread shallow

Then:

git send-email -8 --cover-letter

will automatically send 8 messages all in reply to the cover letter, 
creating a single thread.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org




More information about the libvir-list mailing list