[libvirt] [PATCH] qemu: respect locking rules
Eric Blake
eblake at redhat.com
Fri Mar 18 19:41:45 UTC 2011
On 03/18/2011 12:11 PM, Daniel P. Berrange wrote:
> On Mon, Mar 14, 2011 at 08:38:09PM -0600, Eric Blake wrote:
>> THREADS.txt states that the contents of vm should not be read or
>> modified while the vm lock is not held, but that the lock must not
>> be held while performing a monitor command. This fixes all the
>> offenders that I could find.
>>
>> @@ -2210,8 +2213,9 @@ int qemuProcessStart(virConnectPtr conn,
>> }
>>
>> VIR_DEBUG0("Setting initial memory amount");
>> + cur_balloon = vm->def->mem.cur_balloon;
>> qemuDomainObjEnterMonitorWithDriver(driver, vm);
>> - if (qemuMonitorSetBalloon(priv->mon, vm->def->mem.cur_balloon) < 0) {
>> + if (qemuMonitorSetBalloon(priv->mon, cur_balloon) < 0) {
>> qemuDomainObjExitMonitorWithDriver(driver, vm);
>> goto cleanup;
>> }
>
> ACK
Thanks; pushed.
--
Eric Blake eblake at redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20110318/034c09fc/attachment-0001.sig>
More information about the libvir-list
mailing list