[libvirt] [PATCH] Fix a memory leak

Stefan Berger stefanb at linux.vnet.ibm.com
Tue Apr 17 19:15:48 UTC 2012


On 04/17/2012 03:03 PM, Eric Blake wrote:
> On 04/17/2012 12:55 PM, Stefan Berger wrote:
>
>>       }
>>
>> +    dest->type = src->type;
>> +
> ACK.  No good writing into a union if you forget to also update the
> discriminator to say which branch of the union is active.  The missing
> assignment definitely explains the memory leak.
>
Pushed.




More information about the libvir-list mailing list