[libvirt] [PATCH v3 2/4] qemu: configurable remote display port boundaries

[Daniel P. Berrange]

On Mon, Aug 13, 2012 at 03:21:23PM +0200, Martin Kletzander wrote:
> The defines QEMU_REMOTE_PORT_MIN and QEMU_REMOTE_PORT_MAX were used to
> find free port when starting domains. As this was hard-coded to the
> same ports as default VNC servers, there were races with these other
> programs. This patch includes the possibility to change the default
> starting port as well as the maximum port (mostly for completeness) in
> qemu config file.
> 
> Support for two new config options in qemu.conf is added:
>  - remote_port_min (defaults to QEMU_REMOTE_PORT_MIN and
>    must be >= than this value)
>  - remote_port_max (defaults to QEMU_REMOTE_PORT_MAX and
>    must be <= than this value)
> ---
>  src/qemu/libvirtd_qemu.aug         |    4 +++
>  src/qemu/qemu.conf                 |   14 ++++++++++
>  src/qemu/qemu_command.h            |    7 +++++
>  src/qemu/qemu_conf.c               |   48 +++++++++++++++++++++++++++++++++++-
>  src/qemu/qemu_conf.h               |    2 +
>  src/qemu/qemu_driver.c             |   12 +++++---
>  src/qemu/qemu_process.c            |   14 +++++-----
>  src/qemu/test_libvirtd_qemu.aug.in |    2 +
>  8 files changed, 90 insertions(+), 13 deletions(-)

ACK

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|