[libvirt] [PATCH 0/3] Test case for fdstream / iohelper code

Daniel P. Berrange berrange at redhat.com
Fri May 10 17:17:24 UTC 2013


From: "Daniel P. Berrange" <berrange at redhat.com>

There was a recent embarassing regression in the fdstream
iohelper code which broke many commands/APIs. The problem
code in question is quite easily testable via the unit tests.

Daniel P. Berrange (3):
  Add a virGetLastErrorMessage() function
  Allow the iohelper path to be customized by test programs
  Add a test case for the fdstream file read/write code

 .gitignore                  |   1 +
 include/libvirt/virterror.h |   2 +
 src/fdstream.c              |  14 +-
 src/fdstream.h              |   3 +
 src/libvirt_private.syms    |   1 +
 src/libvirt_public.syms     |   5 +
 src/util/virerror.c         |  21 +++
 tests/Makefile.am           |   5 +
 tests/fdstreamtest.c        | 353 ++++++++++++++++++++++++++++++++++++++++++++
 9 files changed, 404 insertions(+), 1 deletion(-)
 create mode 100644 tests/fdstreamtest.c

-- 
1.8.2.1




More information about the libvir-list mailing list