[libvirt] [PATCH 15/15] build: syntax check to avoid 'const fooPtr'

Daniel P. Berrange berrange at redhat.com
Mon Oct 14 15:35:32 UTC 2013


On Tue, Oct 08, 2013 at 11:29:06AM -0600, Eric Blake wrote:
> 'const fooPtr' is the same as 'foo * const' (the pointer won't
> change, but it's contents can).  But in general, if an interface
> is trying to be const-correct, it should be using 'const foo *'
> (the pointer is to data that can't be changed).
> 
> Now that the code base has been cleaned, enforce it with a syntax
> checker.
> 
> * cfg.mk (sc_forbid_const_pointer_typedef): New rule.
> ---
>  cfg.mk | 8 ++++++++
>  1 file changed, 8 insertions(+)

ACK

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|




More information about the libvir-list mailing list